Refactor err checking

tedyu · yutedz · commit 2472d34bf091 · 2019-04-25T10:18:52.000-07:00
diff --git a/pkg/proxy/ipvs/proxier.go b/pkg/proxy/ipvs/proxier.go
@@ -280,9 +280,11 @@ func parseExcludedCIDRs(excludeCIDRs []string) []*net.IPNet {
 	var cidrExclusions []*net.IPNet
 	for _, excludedCIDR := range excludeCIDRs {
 		_, n, err := net.ParseCIDR(excludedCIDR)
-		if err == nil {
-			cidrExclusions = append(cidrExclusions, n)
+		if err != nil {
+			klog.Errorf("Error parsing exclude CIDR %q,  err: %v", excludedCIDR, err)
+			continue
 		}
+		cidrExclusions = append(cidrExclusions, n)
 	}
 	return cidrExclusions
 }

Original file line number	Diff line number	Diff line change
`@@ -280,9 +280,11 @@ func parseExcludedCIDRs(excludeCIDRs []string) []*net.IPNet {`
`280`	`280`	`var cidrExclusions []*net.IPNet`
`281`	`281`	`for _, excludedCIDR := range excludeCIDRs {`
`282`	`282`	`_, n, err := net.ParseCIDR(excludedCIDR)`
`283`		`- if err == nil {`
`284`		`- cidrExclusions = append(cidrExclusions, n)`
	`283`	`+ if err != nil {`
	`284`	`+ klog.Errorf("Error parsing exclude CIDR %q, err: %v", excludedCIDR, err)`
	`285`	`+ continue`
`285`	`286`	`}`
	`287`	`+ cidrExclusions = append(cidrExclusions, n)`
`286`	`288`	`}`
`287`	`289`	`return cidrExclusions`
`288`	`290`	`}`