Skip to content

Commit 253797a

Browse files
tedyuyutedz
authored andcommitted
Avoid conflicting log message when AddPodToVolume encounters error
1 parent 9b54021 commit 253797a

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

pkg/kubelet/volumemanager/populator/desired_state_of_world_populator.go

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,7 @@ func (dswp *desiredStateOfWorldPopulator) processPodVolumes(
298298
allVolumesAdded := true
299299
mountsMap, devicesMap := dswp.makeVolumeMap(pod.Spec.Containers)
300300

301+
expandInUsePV := utilfeature.DefaultFeatureGate.Enabled(features.ExpandInUsePersistentVolumes)
301302
// Process volume spec for each volume defined in pod
302303
for _, podVolume := range pod.Spec.Volumes {
303304
pvc, volumeSpec, volumeGidValue, err :=
@@ -325,15 +326,15 @@ func (dswp *desiredStateOfWorldPopulator) processPodVolumes(
325326
err)
326327
dswp.desiredStateOfWorld.AddErrorToPod(uniquePodName, err.Error())
327328
allVolumesAdded = false
329+
} else {
330+
klog.V(4).Infof(
331+
"Added volume %q (volSpec=%q) for pod %q to desired state.",
332+
podVolume.Name,
333+
volumeSpec.Name(),
334+
uniquePodName)
328335
}
329336

330-
klog.V(4).Infof(
331-
"Added volume %q (volSpec=%q) for pod %q to desired state.",
332-
podVolume.Name,
333-
volumeSpec.Name(),
334-
uniquePodName)
335-
336-
if utilfeature.DefaultFeatureGate.Enabled(features.ExpandInUsePersistentVolumes) {
337+
if expandInUsePV {
337338
dswp.checkVolumeFSResize(pod, podVolume, pvc, volumeSpec,
338339
uniquePodName, mountedVolumesForPod, processedVolumesForFSResize)
339340
}

0 commit comments

Comments
 (0)