Skip to content

Commit 25501f8

Browse files
authored
Merge pull request kubernetes#87886 from RA489/rmbasheg
remove bash examples/comments from the v1beta1 and v1beta2 APIs
2 parents b3ba969 + ad9d2d7 commit 25501f8

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

cmd/kubeadm/app/apis/kubeadm/types.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,8 +373,7 @@ type BootstrapTokenDiscovery struct {
373373
// pinning, which can be unsafe. Each hash is specified as "<type>:<value>",
374374
// where the only currently supported type is "sha256". This is a hex-encoded
375375
// SHA-256 hash of the Subject Public Key Info (SPKI) object in DER-encoded
376-
// ASN.1. These hashes can be calculated using, for example, OpenSSL:
377-
// openssl x509 -pubkey -in ca.crt openssl rsa -pubin -outform der 2>&/dev/null | openssl dgst -sha256 -hex
376+
// ASN.1. These hashes can be calculated using, for example, OpenSSL.
378377
CACertHashes []string
379378

380379
// UnsafeSkipCAVerification allows token-based discovery

cmd/kubeadm/app/apis/kubeadm/v1beta1/types.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -362,8 +362,7 @@ type BootstrapTokenDiscovery struct {
362362
// pinning, which can be unsafe. Each hash is specified as "<type>:<value>",
363363
// where the only currently supported type is "sha256". This is a hex-encoded
364364
// SHA-256 hash of the Subject Public Key Info (SPKI) object in DER-encoded
365-
// ASN.1. These hashes can be calculated using, for example, OpenSSL:
366-
// openssl x509 -pubkey -in ca.crt openssl rsa -pubin -outform der 2>&/dev/null | openssl dgst -sha256 -hex
365+
// ASN.1. These hashes can be calculated using, for example, OpenSSL.
367366
CACertHashes []string `json:"caCertHashes,omitempty"`
368367

369368
// UnsafeSkipCAVerification allows token-based discovery

cmd/kubeadm/app/apis/kubeadm/v1beta2/types.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -364,8 +364,7 @@ type BootstrapTokenDiscovery struct {
364364
// pinning, which can be unsafe. Each hash is specified as "<type>:<value>",
365365
// where the only currently supported type is "sha256". This is a hex-encoded
366366
// SHA-256 hash of the Subject Public Key Info (SPKI) object in DER-encoded
367-
// ASN.1. These hashes can be calculated using, for example, OpenSSL:
368-
// openssl x509 -pubkey -in ca.crt openssl rsa -pubin -outform der 2>&/dev/null | openssl dgst -sha256 -hex
367+
// ASN.1. These hashes can be calculated using, for example, OpenSSL.
369368
CACertHashes []string `json:"caCertHashes,omitempty"`
370369

371370
// UnsafeSkipCAVerification allows token-based discovery

cmd/kubeadm/app/util/pubkeypin/pubkeypin_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@ c1vuFqTnJBPcb7W//R/GI2Paicm1cmns9NLnPR35exHxFTy+D1yxmGokpoPMdife
4747
aH+sfuxT8xeTPb3kjzF9eJTlnEquUDLM
4848
-----END CERTIFICATE-----`
4949

50-
// expectedHash can be verified using the openssl CLI:
51-
// openssl x509 -pubkey -in test.crt openssl rsa -pubin -outform der 2>&/dev/null | openssl dgst -sha256 -hex
50+
// expectedHash can be verified using the openssl CLI.
5251
const expectedHash = `sha256:345959acb2c3b2feb87d281961c893f62a314207ef02599f1cc4a5fb255480b3`
5352

5453
// testCert2PEM is a second test cert generated the same way as testCertPEM

0 commit comments

Comments
 (0)