Merge pull request kubernetes#95098 from phunziker/92402-memcache_test

k8s-ci-robot · web-flow · commit 267ba6781e29 · 2020-10-04T11:23:05.000-07:00
Fix vendor/k8s.io/client-go/discovery/cached/memory staticcheck
diff --git a/hack/.staticcheck_failures b/hack/.staticcheck_failures
@@ -50,7 +50,6 @@ vendor/k8s.io/apiserver/plugin/pkg/authenticator/token/webhook
 vendor/k8s.io/apiserver/plugin/pkg/authorizer/webhook
 vendor/k8s.io/cli-runtime/pkg/printers
 vendor/k8s.io/client-go/discovery
-vendor/k8s.io/client-go/discovery/cached/memory
 vendor/k8s.io/client-go/dynamic/fake
 vendor/k8s.io/client-go/metadata/fake
 vendor/k8s.io/client-go/rest
diff --git a/staging/src/k8s.io/client-go/discovery/cached/memory/memcache_test.go b/staging/src/k8s.io/client-go/discovery/cached/memory/memcache_test.go
@@ -95,6 +95,9 @@ func TestClient(t *testing.T) {
 	if err != nil {
 		t.Errorf("Unexpected error: %v", err)
 	}
+	if e, a := fake.groupList, g; !reflect.DeepEqual(e, a) {
+		t.Errorf("Expected %#v, got %#v", e, a)
+	}
 	if !c.Fresh() {
 		t.Errorf("Expected fresh.")
 	}

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,9 @@ func TestClient(t *testing.T) {`
`95`	`95`	`if err != nil {`
`96`	`96`	`t.Errorf("Unexpected error: %v", err)`
`97`	`97`	`}`
	`98`	`+ if e, a := fake.groupList, g; !reflect.DeepEqual(e, a) {`
	`99`	`+ t.Errorf("Expected %#v, got %#v", e, a)`
	`100`	`+ }`
`98`	`101`	`if !c.Fresh() {`
`99`	`102`	`t.Errorf("Expected fresh.")`
`100`	`103`	`}`