Skip to content

Commit 2704abf

Browse files
committed
fix shellcheck failures of hack/verify-boilerplate.sh verify-cli-conventions.sh verify-codegen.sh
1 parent 33f907a commit 2704abf

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

hack/.shellcheck_failures

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@
3737
./hack/pin-dependency.sh
3838
./hack/test-integration.sh
3939
./hack/update-vendor.sh
40-
./hack/verify-boilerplate.sh
41-
./hack/verify-cli-conventions.sh
42-
./hack/verify-codegen.sh
4340
./hack/verify-golint.sh
4441
./hack/verify-no-vendor-cycles.sh
4542
./hack/verify-test-featuregates.sh

hack/verify-boilerplate.sh

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,15 @@ set -o errexit
1818
set -o nounset
1919
set -o pipefail
2020

21-
KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
21+
KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
2222

2323
boilerDir="${KUBE_ROOT}/hack/boilerplate"
2424
boiler="${boilerDir}/boilerplate.py"
2525

26-
files_need_boilerplate=($(${boiler} "$@"))
26+
files_need_boilerplate=()
27+
while IFS=$'\n' read -r line; do
28+
files_need_boilerplate+=( "$line" )
29+
done < <("${boiler}" "$@")
2730

2831
# Run boilerplate check
2932
if [[ ${#files_need_boilerplate[@]} -gt 0 ]]; then

hack/verify-cli-conventions.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ set -o errexit
1818
set -o nounset
1919
set -o pipefail
2020

21-
KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
21+
KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
2222
source "${KUBE_ROOT}/hack/lib/init.sh"
2323

2424
kube::golang::setup_env

hack/verify-codegen.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ set -o errexit
1818
set -o nounset
1919
set -o pipefail
2020

21-
KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
21+
KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
2222
source "${KUBE_ROOT}/hack/lib/init.sh"
2323

2424
kube::golang::setup_env

0 commit comments

Comments
 (0)