Skip to content

Commit 2bd3226

Browse files
authored
Merge pull request kubernetes#81814 from oomichi/replace-e2elog-framework-job-node
Use log functions of core framework on sub [j-l]
2 parents 0d350d6 + acc0c0c commit 2bd3226

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

test/e2e/framework/job/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ go_library(
2020
"//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library",
2121
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",
2222
"//test/e2e/framework:go_default_library",
23-
"//test/e2e/framework/log:go_default_library",
2423
],
2524
)
2625

test/e2e/framework/job/rest.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import (
2626
"k8s.io/apimachinery/pkg/util/wait"
2727
clientset "k8s.io/client-go/kubernetes"
2828
"k8s.io/kubernetes/test/e2e/framework"
29-
e2elog "k8s.io/kubernetes/test/e2e/framework/log"
3029
)
3130

3231
// GetJob uses c to get the Job in namespace ns named name. If the returned error is nil, the returned Job is valid.
@@ -64,7 +63,7 @@ func UpdateJobWithRetries(c clientset.Interface, namespace, name string, applyUp
6463
// Apply the update, then attempt to push it to the apiserver.
6564
applyUpdate(job)
6665
if job, err = jobs.Update(job); err == nil {
67-
e2elog.Logf("Updating job %s", name)
66+
framework.Logf("Updating job %s", name)
6867
return true, nil
6968
}
7069
updateErr = err

test/e2e/framework/lifecycle/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ go_library(
1010
"//staging/src/k8s.io/apimachinery/pkg/version:go_default_library",
1111
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",
1212
"//test/e2e/framework:go_default_library",
13-
"//test/e2e/framework/log:go_default_library",
1413
],
1514
)
1615

test/e2e/framework/lifecycle/upgrade.go

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,40 +27,39 @@ import (
2727
"k8s.io/apimachinery/pkg/version"
2828
clientset "k8s.io/client-go/kubernetes"
2929
"k8s.io/kubernetes/test/e2e/framework"
30-
e2elog "k8s.io/kubernetes/test/e2e/framework/log"
3130
)
3231

3332
// RealVersion turns a version constants into a version string deployable on
3433
// GKE. See hack/get-build.sh for more information.
3534
func RealVersion(s string) (string, error) {
36-
e2elog.Logf("Getting real version for %q", s)
35+
framework.Logf("Getting real version for %q", s)
3736
v, _, err := framework.RunCmd(path.Join(framework.TestContext.RepoRoot, "hack/get-build.sh"), "-v", s)
3837
if err != nil {
3938
return v, fmt.Errorf("error getting real version for %q: %v", s, err)
4039
}
41-
e2elog.Logf("Version for %q is %q", s, v)
40+
framework.Logf("Version for %q is %q", s, v)
4241
return strings.TrimPrefix(strings.TrimSpace(v), "v"), nil
4342
}
4443

4544
func traceRouteToMaster() {
4645
traceroute, err := exec.LookPath("traceroute")
4746
if err != nil {
48-
e2elog.Logf("Could not find traceroute program")
47+
framework.Logf("Could not find traceroute program")
4948
return
5049
}
5150
cmd := exec.Command(traceroute, "-I", framework.GetMasterHost())
5251
out, err := cmd.Output()
5352
if len(out) != 0 {
54-
e2elog.Logf(string(out))
53+
framework.Logf(string(out))
5554
}
5655
if exiterr, ok := err.(*exec.ExitError); err != nil && ok {
57-
e2elog.Logf("Error while running traceroute: %s", exiterr.Stderr)
56+
framework.Logf("Error while running traceroute: %s", exiterr.Stderr)
5857
}
5958
}
6059

6160
// CheckMasterVersion validates the master version
6261
func CheckMasterVersion(c clientset.Interface, want string) error {
63-
e2elog.Logf("Checking master version")
62+
framework.Logf("Checking master version")
6463
var err error
6564
var v *version.Info
6665
waitErr := wait.PollImmediate(5*time.Second, 2*time.Minute, func() (bool, error) {
@@ -81,7 +80,7 @@ func CheckMasterVersion(c clientset.Interface, want string) error {
8180
if !strings.HasPrefix(got, want) {
8281
return fmt.Errorf("master had kube-apiserver version %s which does not start with %s", got, want)
8382
}
84-
e2elog.Logf("Master is at version %s", want)
83+
framework.Logf("Master is at version %s", want)
8584
return nil
8685
}
8786

0 commit comments

Comments
 (0)