Skip to content

Commit 2d2c9a8

Browse files
committed
Revert "Merge pull request kubernetes#86376 from xieyanker/kubemark_deployment"
This reverts commit 661a08d, reversing changes made to 8cd8784.
1 parent b632ead commit 2d2c9a8

File tree

4 files changed

+16
-18
lines changed

4 files changed

+16
-18
lines changed

test/kubemark/iks/startup.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ KUBEMARK_DIRECTORY="${KUBE_ROOT}/test/kubemark"
2121
RESOURCE_DIRECTORY="${KUBEMARK_DIRECTORY}/resources"
2222

2323
# Generate secret and configMap for the hollow-node pods to work, prepare
24-
# manifests of the hollow-node and heapster deployments from templates,
25-
# and finally create these resources through kubectl.
24+
# manifests of the hollow-node and heapster replication controllers from
25+
# templates, and finally create these resources through kubectl.
2626
function create-kube-hollow-node-resources {
2727
# Create kubeconfig for Kubelet.
2828
KUBELET_KUBECONFIG_CONTENTS="$(cat <<EOF
@@ -225,7 +225,7 @@ EOF
225225
"${KUBECTL}" create -f "${RESOURCE_DIRECTORY}/addons" --namespace="kubemark"
226226
set-registry-secrets
227227

228-
# Create the deployment for hollow-nodes.
228+
# Create the replication controller for hollow-nodes.
229229
# We allow to override the NUM_REPLICAS when running Cluster Autoscaler.
230230
NUM_REPLICAS=${NUM_REPLICAS:-${KUBEMARK_NUM_NODES}}
231231
sed "s/{{numreplicas}}/${NUM_REPLICAS}/g" "${RESOURCE_DIRECTORY}/hollow-node_template.yaml" > "${RESOURCE_DIRECTORY}/hollow-node.yaml"
@@ -250,7 +250,7 @@ EOF
250250
sed -i'' -e "s'{{kubemark_mig_config}}'${KUBEMARK_MIG_CONFIG:-}'g" "${RESOURCE_DIRECTORY}/hollow-node.yaml"
251251
"${KUBECTL}" create -f "${RESOURCE_DIRECTORY}/hollow-node.yaml" --namespace="kubemark"
252252

253-
echo "Created secrets, configMaps, deployments required for hollow-nodes."
253+
echo "Created secrets, configMaps, replication-controllers required for hollow-nodes."
254254
}
255255

256256
# Wait until all hollow-nodes are running or there is a timeout.
@@ -318,4 +318,4 @@ echo ""
318318
# shellcheck disable=SC2154 # Color defined in sourced script
319319
echo -e "${color_blue}SUCCESS${color_norm}"
320320
clean-repo
321-
exit 0
321+
exit 0

test/kubemark/resources/heapster_template.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"kind": "Deployment",
3-
"apiVersion": "apps/v1",
2+
"kind": "ReplicationController",
3+
"apiVersion": "v1",
44
"metadata": {
55
"name": "heapster-v1.3.0",
66
"labels": {
@@ -11,9 +11,8 @@
1111
"spec": {
1212
"replicas": 1,
1313
"selector": {
14-
"matchLabels":
15-
"k8s-app": "heapster",
16-
"version": "v1.3.0"
14+
"k8s-app": "heapster",
15+
"version": "v1.3.0"
1716
},
1817
"template": {
1918
"metadata": {

test/kubemark/resources/hollow-node_template.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
apiVersion: apps/v1
2-
kind: Deployment
1+
apiVersion: v1
2+
kind: ReplicationController
33
metadata:
44
name: hollow-node
55
labels:
@@ -8,8 +8,7 @@ metadata:
88
spec:
99
replicas: {{numreplicas}}
1010
selector:
11-
matchLabels:
12-
name: hollow-node
11+
name: hollow-node
1312
template:
1413
metadata:
1514
labels:

test/kubemark/start-kubemark.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ function delete-kubemark-image {
8282
}
8383

8484
# Generate secret and configMap for the hollow-node pods to work, prepare
85-
# manifests of the hollow-node and heapster deployments from templates,
86-
# and finally create these resources through kubectl.
85+
# manifests of the hollow-node and heapster replication controllers from
86+
# templates, and finally create these resources through kubectl.
8787
function create-kube-hollow-node-resources {
8888
# Create kubemark namespace.
8989
"${KUBECTL}" create -f "${RESOURCE_DIRECTORY}/kubemark-ns.json"
@@ -142,7 +142,7 @@ function create-kube-hollow-node-resources {
142142

143143
"${KUBECTL}" create -f "${RESOURCE_DIRECTORY}/addons" --namespace="kubemark"
144144

145-
# Create the deployment for hollow-nodes.
145+
# Create the replication controller for hollow-nodes.
146146
# We allow to override the NUM_REPLICAS when running Cluster Autoscaler.
147147
NUM_REPLICAS=${NUM_REPLICAS:-${NUM_NODES}}
148148
sed "s@{{numreplicas}}@${NUM_REPLICAS}@g" "${RESOURCE_DIRECTORY}/hollow-node_template.yaml" > "${RESOURCE_DIRECTORY}/hollow-node.yaml"
@@ -174,7 +174,7 @@ function create-kube-hollow-node-resources {
174174
sed -i'' -e "s@{{kubemark_mig_config}}@${KUBEMARK_MIG_CONFIG:-}@g" "${RESOURCE_DIRECTORY}/hollow-node.yaml"
175175
"${KUBECTL}" create -f "${RESOURCE_DIRECTORY}/hollow-node.yaml" --namespace="kubemark"
176176

177-
echo "Created secrets, configMaps, deployments required for hollow-nodes."
177+
echo "Created secrets, configMaps, replication-controllers required for hollow-nodes."
178178
}
179179

180180
# Wait until all hollow-nodes are running or there is a timeout.

0 commit comments

Comments
 (0)