Skip to content

Commit 2db51c8

Browse files
authored
Merge pull request kubernetes#89187 from andrewsykim/e2e-framework-jobs
e2e/framework: remove imports to pkg/controller/job
2 parents 71839b5 + 6c7bb45 commit 2db51c8

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

test/e2e/framework/job/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ go_library(
1111
importpath = "k8s.io/kubernetes/test/e2e/framework/job",
1212
visibility = ["//visibility:public"],
1313
deps = [
14-
"//pkg/controller/job:go_default_library",
1514
"//staging/src/k8s.io/api/batch/v1:go_default_library",
1615
"//staging/src/k8s.io/api/core/v1:go_default_library",
1716
"//staging/src/k8s.io/apimachinery/pkg/api/errors:go_default_library",

test/e2e/framework/job/wait.go

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ import (
2020
"context"
2121
"time"
2222

23+
batchv1 "k8s.io/api/batch/v1"
2324
"k8s.io/api/core/v1"
2425
apierrors "k8s.io/apimachinery/pkg/api/errors"
2526
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2627
"k8s.io/apimachinery/pkg/util/wait"
2728
clientset "k8s.io/client-go/kubernetes"
28-
jobutil "k8s.io/kubernetes/pkg/controller/job"
2929
"k8s.io/kubernetes/test/e2e/framework"
3030
)
3131

@@ -65,10 +65,21 @@ func WaitForJobFinish(c clientset.Interface, ns, jobName string) error {
6565
if err != nil {
6666
return false, err
6767
}
68-
return jobutil.IsJobFinished(curr), nil
68+
69+
return isJobFinished(curr), nil
6970
})
7071
}
7172

73+
func isJobFinished(j *batchv1.Job) bool {
74+
for _, c := range j.Status.Conditions {
75+
if (c.Type == batchv1.JobComplete || c.Type == batchv1.JobFailed) && c.Status == v1.ConditionTrue {
76+
return true
77+
}
78+
}
79+
80+
return false
81+
}
82+
7283
// WaitForJobGone uses c to wait for up to timeout for the Job named jobName in namespace ns to be removed.
7384
func WaitForJobGone(c clientset.Interface, ns, jobName string, timeout time.Duration) error {
7485
return wait.Poll(framework.Poll, timeout, func() (bool, error) {

0 commit comments

Comments
 (0)