Skip to content

Commit 2f852a2

Browse files
committed
Fix double error of secret negative testcase
E2E Test "Secret should fail to create secret in volume due to empty secret key" tries to create a secret with empty key and check whether it fails or not. But the secret creation in this test fails with double error due to invalid secret name. This will make this test to pass even if the fuctionality which needs to be tested is broken. This commit fix the secret name error(name should not have capital letters) so that the secret creation fails only due to desired reason. Signed-off-by: kanwar saad bin liaqat <[email protected]>
1 parent 118e33d commit 2f852a2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/e2e/common/secrets.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ func newEnvFromSecret(namespace, name string) *v1.Secret {
147147
}
148148

149149
func createEmptyKeySecretForTest(f *framework.Framework) (*v1.Secret, error) {
150-
secretName := "secret-emptyKey-test-" + string(uuid.NewUUID())
150+
secretName := "secret-emptykey-test-" + string(uuid.NewUUID())
151151
secret := &v1.Secret{
152152
ObjectMeta: metav1.ObjectMeta{
153153
Namespace: f.Namespace.Name,

0 commit comments

Comments
 (0)