Skip to content

Commit 30e7016

Browse files
ahg-gahg-g
committed
Refactor scheduler.New so that all framework-related parameters are passed as options
1 parent 8b611ac commit 30e7016

File tree

17 files changed

+216
-279
lines changed

17 files changed

+216
-279
lines changed

‎cmd/kube-scheduler/app/server.go‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,14 +182,15 @@ func Run(cc schedulerserverconfig.CompletedConfig, stopCh <-chan struct{}, regis
182182
cc.Recorder,
183183
cc.ComponentConfig.AlgorithmSource,
184184
stopCh,
185-
registry,
186-
cc.ComponentConfig.Plugins,
187-
cc.ComponentConfig.PluginConfig,
188185
scheduler.WithName(cc.ComponentConfig.SchedulerName),
189186
scheduler.WithHardPodAffinitySymmetricWeight(cc.ComponentConfig.HardPodAffinitySymmetricWeight),
190187
scheduler.WithPreemptionDisabled(cc.ComponentConfig.DisablePreemption),
191188
scheduler.WithPercentageOfNodesToScore(cc.ComponentConfig.PercentageOfNodesToScore),
192-
scheduler.WithBindTimeoutSeconds(*cc.ComponentConfig.BindTimeoutSeconds))
189+
scheduler.WithBindTimeoutSeconds(*cc.ComponentConfig.BindTimeoutSeconds),
190+
scheduler.WithFrameworkRegistry(registry),
191+
scheduler.WithFrameworkPlugins(cc.ComponentConfig.Plugins),
192+
scheduler.WithFrameworkPluginConfig(cc.ComponentConfig.PluginConfig),
193+
)
193194
if err != nil {
194195
return err
195196
}

‎pkg/scheduler/BUILD‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ go_library(
1515
"//pkg/scheduler/apis/config:go_default_library",
1616
"//pkg/scheduler/core:go_default_library",
1717
"//pkg/scheduler/factory:go_default_library",
18+
"//pkg/scheduler/framework/plugins:go_default_library",
1819
"//pkg/scheduler/framework/v1alpha1:go_default_library",
1920
"//pkg/scheduler/internal/cache:go_default_library",
2021
"//pkg/scheduler/internal/queue:go_default_library",

‎pkg/scheduler/api/compatibility/BUILD‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ go_test(
1111
"//pkg/scheduler/apis/config:go_default_library",
1212
"//pkg/scheduler/core:go_default_library",
1313
"//pkg/scheduler/factory:go_default_library",
14-
"//pkg/scheduler/framework/plugins:go_default_library",
1514
"//staging/src/k8s.io/api/core/v1:go_default_library",
1615
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
1716
"//staging/src/k8s.io/apimachinery/pkg/util/sets:go_default_library",

‎pkg/scheduler/api/compatibility/compatibility_test.go‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import (
3232
schedulerconfig "k8s.io/kubernetes/pkg/scheduler/apis/config"
3333
"k8s.io/kubernetes/pkg/scheduler/core"
3434
"k8s.io/kubernetes/pkg/scheduler/factory"
35-
schedulerframework "k8s.io/kubernetes/pkg/scheduler/framework/plugins"
3635
)
3736

3837
func TestCompatibility_v1_Scheduler(t *testing.T) {
@@ -1163,9 +1162,6 @@ func TestCompatibility_v1_Scheduler(t *testing.T) {
11631162
nil,
11641163
algorithmSrc,
11651164
make(chan struct{}),
1166-
schedulerframework.NewDefaultRegistry(),
1167-
nil,
1168-
[]kubeschedulerconfig.PluginConfig{},
11691165
)
11701166
if err != nil {
11711167
t.Fatalf("%s: Error constructing: %v", v, err)

‎pkg/scheduler/scheduler.go‎

Lines changed: 58 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ import (
4040
kubeschedulerconfig "k8s.io/kubernetes/pkg/scheduler/apis/config"
4141
"k8s.io/kubernetes/pkg/scheduler/core"
4242
"k8s.io/kubernetes/pkg/scheduler/factory"
43+
frameworkplugins "k8s.io/kubernetes/pkg/scheduler/framework/plugins"
4344
framework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
4445
internalcache "k8s.io/kubernetes/pkg/scheduler/internal/cache"
4546
internalqueue "k8s.io/kubernetes/pkg/scheduler/internal/queue"
@@ -109,11 +110,15 @@ func (sched *Scheduler) Cache() internalcache.Cache {
109110
}
110111

111112
type schedulerOptions struct {
112-
schedulerName string
113-
hardPodAffinitySymmetricWeight int32
114-
disablePreemption bool
115-
percentageOfNodesToScore int32
116-
bindTimeoutSeconds int64
113+
schedulerName string
114+
hardPodAffinitySymmetricWeight int32
115+
disablePreemption bool
116+
percentageOfNodesToScore int32
117+
bindTimeoutSeconds int64
118+
frameworkRegistry framework.Registry
119+
frameworkConfigProducerRegistry *frameworkplugins.ConfigProducerRegistry
120+
frameworkPlugins *kubeschedulerconfig.Plugins
121+
frameworkPluginConfig []kubeschedulerconfig.PluginConfig
117122
}
118123

119124
// Option configures a Scheduler
@@ -154,12 +159,51 @@ func WithBindTimeoutSeconds(bindTimeoutSeconds int64) Option {
154159
}
155160
}
156161

162+
// WithFrameworkRegistry sets the framework registry.
163+
func WithFrameworkRegistry(registry framework.Registry) Option {
164+
return func(o *schedulerOptions) {
165+
o.frameworkRegistry = registry
166+
}
167+
}
168+
169+
// WithFrameworkConfigProducerRegistry sets the framework plugin producer registry.
170+
func WithFrameworkConfigProducerRegistry(registry *frameworkplugins.ConfigProducerRegistry) Option {
171+
return func(o *schedulerOptions) {
172+
o.frameworkConfigProducerRegistry = registry
173+
}
174+
}
175+
176+
// WithFrameworkPlugins sets the plugins that the framework should be configured with.
177+
func WithFrameworkPlugins(plugins *kubeschedulerconfig.Plugins) Option {
178+
return func(o *schedulerOptions) {
179+
o.frameworkPlugins = plugins
180+
}
181+
}
182+
183+
// WithFrameworkPluginConfig sets the PluginConfig slice that the framework should be configured with.
184+
func WithFrameworkPluginConfig(pluginConfig []kubeschedulerconfig.PluginConfig) Option {
185+
return func(o *schedulerOptions) {
186+
o.frameworkPluginConfig = pluginConfig
187+
}
188+
}
189+
157190
var defaultSchedulerOptions = schedulerOptions{
158-
schedulerName: v1.DefaultSchedulerName,
159-
hardPodAffinitySymmetricWeight: v1.DefaultHardPodAffinitySymmetricWeight,
160-
disablePreemption: false,
161-
percentageOfNodesToScore: schedulerapi.DefaultPercentageOfNodesToScore,
162-
bindTimeoutSeconds: BindTimeoutSeconds,
191+
schedulerName: v1.DefaultSchedulerName,
192+
hardPodAffinitySymmetricWeight: v1.DefaultHardPodAffinitySymmetricWeight,
193+
disablePreemption: false,
194+
percentageOfNodesToScore: schedulerapi.DefaultPercentageOfNodesToScore,
195+
bindTimeoutSeconds: BindTimeoutSeconds,
196+
frameworkRegistry: frameworkplugins.NewDefaultRegistry(),
197+
frameworkConfigProducerRegistry: frameworkplugins.NewDefaultConfigProducerRegistry(),
198+
// The plugins and pluginConfig options are currently nil because we currently don't have
199+
// "default" plugins. All plugins that we run through the framework currently come from two
200+
// sources: 1) specified in component config, in which case those two options should be
201+
// set using their corresponding With* functions, 2) predicate/priority-mapped plugins, which
202+
// pluginConfigProducerRegistry contains a mapping for and produces their configurations.
203+
// TODO(ahg-g) Once predicates and priorities are migrated to natively run as plugins, the
204+
// below two parameters will be populated accordingly.
205+
frameworkPlugins: nil,
206+
frameworkPluginConfig: nil,
163207
}
164208

165209
// New returns a Scheduler
@@ -178,9 +222,6 @@ func New(client clientset.Interface,
178222
recorder events.EventRecorder,
179223
schedulerAlgorithmSource kubeschedulerconfig.SchedulerAlgorithmSource,
180224
stopCh <-chan struct{},
181-
registry framework.Registry,
182-
plugins *kubeschedulerconfig.Plugins,
183-
pluginConfig []kubeschedulerconfig.PluginConfig,
184225
opts ...Option) (*Scheduler, error) {
185226

186227
options := defaultSchedulerOptions
@@ -205,9 +246,10 @@ func New(client clientset.Interface,
205246
DisablePreemption: options.disablePreemption,
206247
PercentageOfNodesToScore: options.percentageOfNodesToScore,
207248
BindTimeoutSeconds: options.bindTimeoutSeconds,
208-
Registry: registry,
209-
Plugins: plugins,
210-
PluginConfig: pluginConfig,
249+
Registry: options.frameworkRegistry,
250+
PluginConfigProducerRegistry: options.frameworkConfigProducerRegistry,
251+
Plugins: options.frameworkPlugins,
252+
PluginConfig: options.frameworkPluginConfig,
211253
})
212254
var config *factory.Config
213255
source := schedulerAlgorithmSource

‎pkg/scheduler/scheduler_test.go‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,9 @@ import (
5959

6060
var (
6161
emptyPluginRegistry = framework.Registry{}
62-
// emptyPluginConfig is an empty plugin config used in tests.
63-
emptyPluginConfig []kubeschedulerconfig.PluginConfig
6462
// emptyFramework is an empty framework used in tests.
6563
// Note: If the test runs in goroutine, please don't use this variable to avoid a race condition.
66-
emptyFramework, _ = framework.NewFramework(emptyPluginRegistry, nil, emptyPluginConfig)
64+
emptyFramework, _ = framework.NewFramework(emptyPluginRegistry, nil, nil)
6765
)
6866

6967
type fakeBinder struct {
@@ -178,7 +176,6 @@ func TestSchedulerCreation(t *testing.T) {
178176
testSource := "testProvider"
179177
eventBroadcaster := events.NewBroadcaster(&events.EventSinkImpl{Interface: client.EventsV1beta1().Events("")})
180178

181-
defaultBindTimeout := int64(30)
182179
factory.RegisterFitPredicate("PredicateOne", PredicateOne)
183180
factory.RegisterPriorityFunction("PriorityOne", PriorityOne, 1)
184181
factory.RegisterAlgorithmProvider(testSource, sets.NewString("PredicateOne"), sets.NewString("PriorityOne"))
@@ -200,10 +197,7 @@ func TestSchedulerCreation(t *testing.T) {
200197
eventBroadcaster.NewRecorder(scheme.Scheme, "scheduler"),
201198
kubeschedulerconfig.SchedulerAlgorithmSource{Provider: &testSource},
202199
stopCh,
203-
emptyPluginRegistry,
204-
nil,
205-
emptyPluginConfig,
206-
WithBindTimeoutSeconds(defaultBindTimeout))
200+
)
207201

208202
if err != nil {
209203
t.Fatalf("Failed to create scheduler: %v", err)

‎test/integration/daemonset/BUILD‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ go_test(
2323
"//pkg/scheduler/algorithmprovider:go_default_library",
2424
"//pkg/scheduler/api:go_default_library",
2525
"//pkg/scheduler/apis/config:go_default_library",
26-
"//pkg/scheduler/framework/plugins:go_default_library",
2726
"//pkg/util/labels:go_default_library",
2827
"//staging/src/k8s.io/api/apps/v1:go_default_library",
2928
"//staging/src/k8s.io/api/core/v1:go_default_library",

‎test/integration/daemonset/daemonset_test.go‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ import (
5151
"k8s.io/kubernetes/pkg/scheduler/algorithmprovider"
5252
schedulerapi "k8s.io/kubernetes/pkg/scheduler/api"
5353
schedulerconfig "k8s.io/kubernetes/pkg/scheduler/apis/config"
54-
schedulerframework "k8s.io/kubernetes/pkg/scheduler/framework/plugins"
5554
labelsutil "k8s.io/kubernetes/pkg/util/labels"
5655
"k8s.io/kubernetes/test/integration/framework"
5756
)
@@ -126,9 +125,6 @@ func setupScheduler(
126125
Provider: &defaultProviderName,
127126
},
128127
stopCh,
129-
schedulerframework.NewDefaultRegistry(),
130-
nil,
131-
[]schedulerconfig.PluginConfig{},
132128
)
133129
if err != nil {
134130
t.Fatalf("Couldn't create scheduler: %v", err)

‎test/integration/scheduler/BUILD‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,6 @@ go_library(
9797
"//pkg/scheduler/api/latest:go_default_library",
9898
"//pkg/scheduler/apis/config:go_default_library",
9999
"//pkg/scheduler/factory:go_default_library",
100-
"//pkg/scheduler/framework/plugins:go_default_library",
101-
"//pkg/scheduler/framework/v1alpha1:go_default_library",
102100
"//pkg/util/taints:go_default_library",
103101
"//staging/src/k8s.io/api/core/v1:go_default_library",
104102
"//staging/src/k8s.io/api/policy/v1beta1:go_default_library",

0 commit comments

Comments
 (0)