[Scheduler] Map deletion complexity: log(n) => O(1)

Author: gaurav1086

pkg/scheduler/framework/plugins/nodevolumelimits/csi.go

@@ -110,10 +110,8 @@ func (pl *CSILimits) Filter(ctx context.Context, _ *framework.CycleState, pod *v
 
 	attachedVolumeCount := map[string]int{}
 	for volumeUniqueName, volumeLimitKey := range attachedVolumes {
-		if _, ok := newVolumes[volumeUniqueName]; ok {
-			// Don't count single volume used in multiple pods more than once
-			delete(newVolumes, volumeUniqueName)
-		}
+		// Don't count single volume used in multiple pods more than once
+		delete(newVolumes, volumeUniqueName)
 		attachedVolumeCount[volumeLimitKey]++
 	}
 

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go

@@ -244,9 +244,7 @@ func (pl *nonCSILimits) Filter(ctx context.Context, _ *framework.CycleState, pod
 
 	// filter out already-mounted volumes
 	for k := range existingVolumes {
-		if _, ok := newVolumes[k]; ok {
-			delete(newVolumes, k)
-		}
+		delete(newVolumes, k)
 	}
 
 	numNewVolumes := len(newVolumes)