Skip to content

Commit 334d788

Browse files
authored
Merge pull request kubernetes#87299 from mikedanese/ctx
context in client-go
2 parents 06c639f + 2637772 commit 334d788

File tree

954 files changed

+8534
-7715
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

954 files changed

+8534
-7715
lines changed

cluster/addons/fluentd-elasticsearch/es-image/elasticsearch_logging_discovery.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717
package main
1818

1919
import (
20+
"context"
2021
"flag"
2122
"fmt"
2223
"net"
@@ -102,7 +103,7 @@ func main() {
102103
namespace := metav1.NamespaceSystem
103104
envNamespace := os.Getenv("NAMESPACE")
104105
if envNamespace != "" {
105-
if _, err := client.CoreV1().Namespaces().Get(envNamespace, metav1.GetOptions{}); err != nil {
106+
if _, err := client.CoreV1().Namespaces().Get(context.TODO(), envNamespace, metav1.GetOptions{}); err != nil {
106107
klog.Fatalf("%s namespace doesn't exist: %v", envNamespace, err)
107108
}
108109
namespace = envNamespace
@@ -117,7 +118,7 @@ func main() {
117118
// Look for endpoints associated with the Elasticsearch logging service.
118119
// First wait for the service to become available.
119120
for t := time.Now(); time.Since(t) < 5*time.Minute; time.Sleep(10 * time.Second) {
120-
elasticsearch, err = client.CoreV1().Services(namespace).Get(serviceName, metav1.GetOptions{})
121+
elasticsearch, err = client.CoreV1().Services(namespace).Get(context.TODO(), serviceName, metav1.GetOptions{})
121122
if err == nil {
122123
break
123124
}
@@ -134,7 +135,7 @@ func main() {
134135
// Wait for some endpoints.
135136
count, _ := strconv.Atoi(os.Getenv("MINIMUM_MASTER_NODES"))
136137
for t := time.Now(); time.Since(t) < 5*time.Minute; time.Sleep(10 * time.Second) {
137-
endpoints, err = client.CoreV1().Endpoints(namespace).Get(serviceName, metav1.GetOptions{})
138+
endpoints, err = client.CoreV1().Endpoints(namespace).Get(context.TODO(), serviceName, metav1.GetOptions{})
138139
if err != nil {
139140
continue
140141
}

cmd/kube-apiserver/app/testing/testserver.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ func StartTestServer(t Logger, instanceOptions *TestServerInstanceOptions, custo
231231
default:
232232
}
233233

234-
if _, err := client.CoreV1().Namespaces().Get("default", metav1.GetOptions{}); err != nil {
234+
if _, err := client.CoreV1().Namespaces().Get(context.TODO(), "default", metav1.GetOptions{}); err != nil {
235235
if !errors.IsNotFound(err) {
236236
t.Logf("Unable to get default namespace: %v", err)
237237
}

cmd/kubeadm/app/cmd/config.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package cmd
1818

1919
import (
2020
"bytes"
21+
"context"
2122
"fmt"
2223
"io"
2324
"io/ioutil"
@@ -432,7 +433,7 @@ func NewCmdConfigUploadFromFlags(out io.Writer, kubeConfigFile *string) *cobra.C
432433
func RunConfigView(out io.Writer, client clientset.Interface) error {
433434

434435
klog.V(1).Infoln("[config] getting the cluster configuration")
435-
cfgConfigMap, err := client.CoreV1().ConfigMaps(metav1.NamespaceSystem).Get(constants.KubeadmConfigConfigMap, metav1.GetOptions{})
436+
cfgConfigMap, err := client.CoreV1().ConfigMaps(metav1.NamespaceSystem).Get(context.TODO(), constants.KubeadmConfigConfigMap, metav1.GetOptions{})
436437
if err != nil {
437438
return err
438439
}

cmd/kubeadm/app/cmd/phases/join/kubelet.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717
package phases
1818

1919
import (
20+
"context"
2021
"fmt"
2122
"os"
2223

@@ -142,7 +143,7 @@ func runKubeletStartJoinPhase(c workflow.RunData) (returnErr error) {
142143
// A new Node with the same name as an existing control-plane Node can cause undefined
143144
// behavior and ultimately control-plane failure.
144145
klog.V(1).Infof("[kubelet-start] Checking for an existing Node in the cluster with name %q and status %q", nodeName, v1.NodeReady)
145-
node, err := bootstrapClient.CoreV1().Nodes().Get(nodeName, metav1.GetOptions{})
146+
node, err := bootstrapClient.CoreV1().Nodes().Get(context.TODO(), nodeName, metav1.GetOptions{})
146147
if err != nil && !apierrors.IsNotFound(err) {
147148
return errors.Wrapf(err, "cannot get Node %q", nodeName)
148149
}

cmd/kubeadm/app/cmd/token.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717
package cmd
1818

1919
import (
20+
"context"
2021
"fmt"
2122
"io"
2223
"os"
@@ -380,7 +381,7 @@ func RunListTokens(out io.Writer, errW io.Writer, client clientset.Interface, pr
380381
}
381382

382383
klog.V(1).Info("[token] retrieving list of bootstrap tokens")
383-
secrets, err := client.CoreV1().Secrets(metav1.NamespaceSystem).List(listOptions)
384+
secrets, err := client.CoreV1().Secrets(metav1.NamespaceSystem).List(context.TODO(), listOptions)
384385
if err != nil {
385386
return errors.Wrap(err, "failed to list bootstrap tokens")
386387
}
@@ -430,7 +431,7 @@ func RunDeleteTokens(out io.Writer, client clientset.Interface, tokenIDsOrTokens
430431

431432
tokenSecretName := bootstraputil.BootstrapTokenSecretName(tokenID)
432433
klog.V(1).Infof("[token] deleting token %q", tokenID)
433-
if err := client.CoreV1().Secrets(metav1.NamespaceSystem).Delete(tokenSecretName, nil); err != nil {
434+
if err := client.CoreV1().Secrets(metav1.NamespaceSystem).Delete(context.TODO(), tokenSecretName, nil); err != nil {
434435
return errors.Wrapf(err, "failed to delete bootstrap token %q", tokenID)
435436
}
436437
fmt.Fprintf(out, "bootstrap token %q deleted\n", tokenID)

cmd/kubeadm/app/discovery/file/file.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717
package file
1818

1919
import (
20+
"context"
2021
"time"
2122

2223
"github.com/pkg/errors"
@@ -100,7 +101,7 @@ func ValidateConfigInfo(config *clientcmdapi.Config, clustername string, discove
100101

101102
err = wait.Poll(constants.DiscoveryRetryInterval, discoveryTimeout, func() (bool, error) {
102103
var err error
103-
clusterinfoCM, err = client.CoreV1().ConfigMaps(metav1.NamespacePublic).Get(bootstrapapi.ConfigMapClusterInfo, metav1.GetOptions{})
104+
clusterinfoCM, err = client.CoreV1().ConfigMaps(metav1.NamespacePublic).Get(context.TODO(), bootstrapapi.ConfigMapClusterInfo, metav1.GetOptions{})
104105
if err != nil {
105106
if apierrors.IsForbidden(err) {
106107
// If the request is unauthorized, the cluster admin has not granted access to the cluster info configmap for unauthenticated users

cmd/kubeadm/app/discovery/token/token.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ func getClusterInfo(client clientset.Interface, kubeconfig *clientcmdapi.Config,
210210
defer cancel()
211211

212212
wait.JitterUntil(func() {
213-
cm, err = client.CoreV1().ConfigMaps(metav1.NamespacePublic).Get(bootstrapapi.ConfigMapClusterInfo, metav1.GetOptions{})
213+
cm, err = client.CoreV1().ConfigMaps(metav1.NamespacePublic).Get(context.TODO(), bootstrapapi.ConfigMapClusterInfo, metav1.GetOptions{})
214214
if err != nil {
215215
klog.V(1).Infof("[discovery] Failed to request cluster-info, will try again: %v", err)
216216
return

cmd/kubeadm/app/phases/addons/dns/dns.go

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717
package dns
1818

1919
import (
20+
"context"
2021
"encoding/json"
2122
"fmt"
2223
"net"
@@ -58,7 +59,7 @@ const (
5859
// DeployedDNSAddon returns the type of DNS addon currently deployed
5960
func DeployedDNSAddon(client clientset.Interface) (kubeadmapi.DNSAddOnType, string, error) {
6061
deploymentsClient := client.AppsV1().Deployments(metav1.NamespaceSystem)
61-
deployments, err := deploymentsClient.List(metav1.ListOptions{LabelSelector: "k8s-app=kube-dns"})
62+
deployments, err := deploymentsClient.List(context.TODO(), metav1.ListOptions{LabelSelector: "k8s-app=kube-dns"})
6263
if err != nil {
6364
return "", "", errors.Wrap(err, "couldn't retrieve DNS addon deployments")
6465
}
@@ -84,7 +85,7 @@ func DeployedDNSAddon(client clientset.Interface) (kubeadmapi.DNSAddOnType, stri
8485
// deployedDNSReplicas returns the replica count for the current DNS deployment
8586
func deployedDNSReplicas(client clientset.Interface, replicas int32) (*int32, error) {
8687
deploymentsClient := client.AppsV1().Deployments(metav1.NamespaceSystem)
87-
deployments, err := deploymentsClient.List(metav1.ListOptions{LabelSelector: "k8s-app=kube-dns"})
88+
deployments, err := deploymentsClient.List(context.TODO(), metav1.ListOptions{LabelSelector: "k8s-app=kube-dns"})
8889
if err != nil {
8990
return &replicas, errors.Wrap(err, "couldn't retrieve DNS addon deployments")
9091
}
@@ -209,7 +210,7 @@ func coreDNSAddon(cfg *kubeadmapi.ClusterConfiguration, client clientset.Interfa
209210
}
210211

211212
// Get the kube-dns ConfigMap for translation to equivalent CoreDNS Config.
212-
kubeDNSConfigMap, err := client.CoreV1().ConfigMaps(metav1.NamespaceSystem).Get(kubeadmconstants.KubeDNSConfigMap, metav1.GetOptions{})
213+
kubeDNSConfigMap, err := client.CoreV1().ConfigMaps(metav1.NamespaceSystem).Get(context.TODO(), kubeadmconstants.KubeDNSConfigMap, metav1.GetOptions{})
213214
if err != nil && !apierrors.IsNotFound(err) {
214215
return err
215216
}
@@ -346,15 +347,15 @@ func createDNSService(dnsService *v1.Service, serviceBytes []byte, client client
346347
}
347348

348349
// Can't use a generic apiclient helper func here as we have to tolerate more than AlreadyExists.
349-
if _, err := client.CoreV1().Services(metav1.NamespaceSystem).Create(dnsService); err != nil {
350+
if _, err := client.CoreV1().Services(metav1.NamespaceSystem).Create(context.TODO(), dnsService); err != nil {
350351
// Ignore if the Service is invalid with this error message:
351352
// Service "kube-dns" is invalid: spec.clusterIP: Invalid value: "10.96.0.10": provided IP is already allocated
352353

353354
if !apierrors.IsAlreadyExists(err) && !apierrors.IsInvalid(err) {
354355
return errors.Wrap(err, "unable to create a new DNS service")
355356
}
356357

357-
if _, err := client.CoreV1().Services(metav1.NamespaceSystem).Update(dnsService); err != nil {
358+
if _, err := client.CoreV1().Services(metav1.NamespaceSystem).Update(context.TODO(), dnsService); err != nil {
358359
return errors.Wrap(err, "unable to create/update the DNS service")
359360
}
360361
}
@@ -373,7 +374,7 @@ func migrateCoreDNSCorefile(client clientset.Interface, cm *v1.ConfigMap, corefi
373374
// Take a copy of the Corefile data as `Corefile-backup` and update the ConfigMap
374375
// Also point the CoreDNS deployment to the `Corefile-backup` data.
375376

376-
if _, err := client.CoreV1().ConfigMaps(cm.ObjectMeta.Namespace).Update(&v1.ConfigMap{
377+
if _, err := client.CoreV1().ConfigMaps(cm.ObjectMeta.Namespace).Update(context.TODO(), &v1.ConfigMap{
377378
ObjectMeta: metav1.ObjectMeta{
378379
Name: kubeadmconstants.CoreDNSConfigMap,
379380
Namespace: metav1.NamespaceSystem,
@@ -395,7 +396,7 @@ func migrateCoreDNSCorefile(client clientset.Interface, cm *v1.ConfigMap, corefi
395396
return errors.Wrap(err, "unable to migrate CoreDNS ConfigMap")
396397
}
397398

398-
if _, err := client.CoreV1().ConfigMaps(cm.ObjectMeta.Namespace).Update(&v1.ConfigMap{
399+
if _, err := client.CoreV1().ConfigMaps(cm.ObjectMeta.Namespace).Update(context.TODO(), &v1.ConfigMap{
399400
ObjectMeta: metav1.ObjectMeta{
400401
Name: kubeadmconstants.CoreDNSConfigMap,
401402
Namespace: metav1.NamespaceSystem,
@@ -424,7 +425,7 @@ func migrateCoreDNSCorefile(client clientset.Interface, cm *v1.ConfigMap, corefi
424425

425426
// GetCoreDNSInfo gets the current CoreDNS installed and the current Corefile Configuration of CoreDNS.
426427
func GetCoreDNSInfo(client clientset.Interface) (*v1.ConfigMap, string, string, error) {
427-
coreDNSConfigMap, err := client.CoreV1().ConfigMaps(metav1.NamespaceSystem).Get(kubeadmconstants.CoreDNSConfigMap, metav1.GetOptions{})
428+
coreDNSConfigMap, err := client.CoreV1().ConfigMaps(metav1.NamespaceSystem).Get(context.TODO(), kubeadmconstants.CoreDNSConfigMap, metav1.GetOptions{})
428429
if err != nil && !apierrors.IsNotFound(err) {
429430
return nil, "", "", err
430431
}
@@ -445,13 +446,13 @@ func GetCoreDNSInfo(client clientset.Interface) (*v1.ConfigMap, string, string,
445446
}
446447

447448
func patchCoreDNSDeployment(client clientset.Interface, coreDNSCorefileName string) error {
448-
dnsDeployment, err := client.AppsV1().Deployments(metav1.NamespaceSystem).Get(kubeadmconstants.CoreDNSDeploymentName, metav1.GetOptions{})
449+
dnsDeployment, err := client.AppsV1().Deployments(metav1.NamespaceSystem).Get(context.TODO(), kubeadmconstants.CoreDNSDeploymentName, metav1.GetOptions{})
449450
if err != nil {
450451
return err
451452
}
452453
patch := fmt.Sprintf(`{"spec":{"template":{"spec":{"volumes":[{"name": "config-volume", "configMap":{"name": "coredns", "items":[{"key": "%s", "path": "%s"}]}}]}}}}`, coreDNSCorefileName, coreDNSCorefileName)
453454

454-
if _, err := client.AppsV1().Deployments(dnsDeployment.ObjectMeta.Namespace).Patch(dnsDeployment.Name, types.StrategicMergePatchType, []byte(patch)); err != nil {
455+
if _, err := client.AppsV1().Deployments(dnsDeployment.ObjectMeta.Namespace).Patch(context.TODO(), dnsDeployment.Name, types.StrategicMergePatchType, []byte(patch)); err != nil {
455456
return errors.Wrap(err, "unable to patch the CoreDNS deployment")
456457
}
457458
return nil

cmd/kubeadm/app/phases/addons/dns/dns_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717
package dns
1818

1919
import (
20+
"context"
2021
"strings"
2122
"testing"
2223

@@ -722,7 +723,7 @@ func TestCreateCoreDNSConfigMap(t *testing.T) {
722723
if err != nil {
723724
t.Fatalf("error creating the CoreDNS ConfigMap: %v", err)
724725
}
725-
migratedConfigMap, _ := client.CoreV1().ConfigMaps(metav1.NamespaceSystem).Get(kubeadmconstants.CoreDNSConfigMap, metav1.GetOptions{})
726+
migratedConfigMap, _ := client.CoreV1().ConfigMaps(metav1.NamespaceSystem).Get(context.TODO(), kubeadmconstants.CoreDNSConfigMap, metav1.GetOptions{})
726727
if !strings.EqualFold(migratedConfigMap.Data["Corefile"], tc.expectedCorefileData) {
727728
t.Fatalf("expected to get %v, but got %v", tc.expectedCorefileData, migratedConfigMap.Data["Corefile"])
728729
}
@@ -732,7 +733,7 @@ func TestCreateCoreDNSConfigMap(t *testing.T) {
732733

733734
func createClientAndCoreDNSManifest(t *testing.T, corefile, coreDNSVersion string) *clientsetfake.Clientset {
734735
client := clientsetfake.NewSimpleClientset()
735-
_, err := client.CoreV1().ConfigMaps(metav1.NamespaceSystem).Create(&v1.ConfigMap{
736+
_, err := client.CoreV1().ConfigMaps(metav1.NamespaceSystem).Create(context.TODO(), &v1.ConfigMap{
736737
ObjectMeta: metav1.ObjectMeta{
737738
Name: kubeadmconstants.CoreDNSConfigMap,
738739
Namespace: metav1.NamespaceSystem,
@@ -744,7 +745,7 @@ func createClientAndCoreDNSManifest(t *testing.T, corefile, coreDNSVersion strin
744745
if err != nil {
745746
t.Fatalf("error creating ConfigMap: %v", err)
746747
}
747-
_, err = client.AppsV1().Deployments(metav1.NamespaceSystem).Create(&apps.Deployment{
748+
_, err = client.AppsV1().Deployments(metav1.NamespaceSystem).Create(context.TODO(), &apps.Deployment{
748749
TypeMeta: metav1.TypeMeta{
749750
Kind: "Deployment",
750751
APIVersion: "apps/v1",

cmd/kubeadm/app/phases/bootstraptoken/node/token.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717
package node
1818

1919
import (
20+
"context"
2021
"github.com/pkg/errors"
2122

2223
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -39,7 +40,7 @@ func UpdateOrCreateTokens(client clientset.Interface, failIfExists bool, tokens
3940
for _, token := range tokens {
4041

4142
secretName := bootstraputil.BootstrapTokenSecretName(token.Token.ID)
42-
secret, err := client.CoreV1().Secrets(metav1.NamespaceSystem).Get(secretName, metav1.GetOptions{})
43+
secret, err := client.CoreV1().Secrets(metav1.NamespaceSystem).Get(context.TODO(), secretName, metav1.GetOptions{})
4344
if secret != nil && err == nil && failIfExists {
4445
return errors.Errorf("a token with id %q already exists", token.Token.ID)
4546
}

0 commit comments

Comments
 (0)