Skip to content

Commit 33bba19

Browse files
authored
Merge pull request kubernetes#86553 from ajayktkp/kubeadm-1985
validation.go: don't clamp the CIDR size calculations
2 parents 14c42b9 + 7271a81 commit 33bba19

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

cmd/kubeadm/app/apis/kubeadm/validation/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ go_library(
2020
"//staging/src/k8s.io/cluster-bootstrap/token/util:go_default_library",
2121
"//vendor/github.com/pkg/errors:go_default_library",
2222
"//vendor/github.com/spf13/pflag:go_default_library",
23-
"//vendor/k8s.io/utils/integer:go_default_library",
2423
"//vendor/k8s.io/utils/net:go_default_library",
2524
],
2625
)

cmd/kubeadm/app/apis/kubeadm/validation/validation.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ import (
3939
"k8s.io/kubernetes/cmd/kubeadm/app/constants"
4040
"k8s.io/kubernetes/cmd/kubeadm/app/features"
4141
kubeadmutil "k8s.io/kubernetes/cmd/kubeadm/app/util"
42-
"k8s.io/utils/integer"
4342
utilnet "k8s.io/utils/net"
4443
)
4544

@@ -385,7 +384,7 @@ func ValidateIPNetFromString(subnetStr string, minAddrs int64, isDualStack bool,
385384
allErrs = append(allErrs, field.Invalid(fldPath, subnetStr, "expected at least one IP from each family (v4 or v6) for dual-stack networking"))
386385
}
387386
for _, s := range subnets {
388-
numAddresses := integer.Int64Min(utilnet.RangeSize(s), 1<<16)
387+
numAddresses := utilnet.RangeSize(s)
389388
if numAddresses < minAddrs {
390389
allErrs = append(allErrs, field.Invalid(fldPath, s, "subnet is too small"))
391390
}
@@ -397,7 +396,7 @@ func ValidateIPNetFromString(subnetStr string, minAddrs int64, isDualStack bool,
397396
allErrs = append(allErrs, field.Invalid(fldPath, subnetStr, "couldn't parse subnet"))
398397
return allErrs
399398
}
400-
numAddresses := integer.Int64Min(utilnet.RangeSize(svcSubnet), 1<<16)
399+
numAddresses := utilnet.RangeSize(svcSubnet)
401400
if numAddresses < minAddrs {
402401
allErrs = append(allErrs, field.Invalid(fldPath, subnetStr, "subnet is too small"))
403402
}

0 commit comments

Comments
 (0)