Skip to content

Commit 36b4c29

Browse files
authored
Merge pull request kubernetes#92815 from Huang-Wei/bypass-prefilter-svcaffinity
Bypass PreFilter in ServiceAfffinity if AffinityLabels arg is not present
2 parents cccb28b + 07583bf commit 36b4c29

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

pkg/scheduler/framework/plugins/serviceaffinity/service_affinity.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,17 +127,23 @@ func (pl *ServiceAffinity) createPreFilterState(pod *v1.Pod) (*preFilterState, e
127127

128128
// PreFilter invoked at the prefilter extension point.
129129
func (pl *ServiceAffinity) PreFilter(ctx context.Context, cycleState *framework.CycleState, pod *v1.Pod) *framework.Status {
130+
if len(pl.args.AffinityLabels) == 0 {
131+
return nil
132+
}
133+
130134
s, err := pl.createPreFilterState(pod)
131135
if err != nil {
132136
return framework.NewStatus(framework.Error, fmt.Sprintf("could not create preFilterState: %v", err))
133-
134137
}
135138
cycleState.Write(preFilterStateKey, s)
136139
return nil
137140
}
138141

139142
// PreFilterExtensions returns prefilter extensions, pod add and remove.
140143
func (pl *ServiceAffinity) PreFilterExtensions() framework.PreFilterExtensions {
144+
if len(pl.args.AffinityLabels) == 0 {
145+
return nil
146+
}
141147
return pl
142148
}
143149

pkg/scheduler/framework/plugins/serviceaffinity/service_affinity_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -500,6 +500,9 @@ func TestPreFilterStateAddRemovePod(t *testing.T) {
500500
p := &ServiceAffinity{
501501
sharedLister: snapshot,
502502
serviceLister: fakeframework.ServiceLister(test.services),
503+
args: config.ServiceAffinityArgs{
504+
AffinityLabels: []string{"region", "zone"},
505+
},
503506
}
504507
cycleState := framework.NewCycleState()
505508
preFilterStatus := p.PreFilter(context.Background(), cycleState, test.pendingPod)

0 commit comments

Comments
 (0)