Skip to content

Commit 3a7b454

Browse files
authored
Merge pull request kubernetes#90437 from iobuf/bugfix
bugfix: staiccheck copylock (holding sync.Once)
2 parents 84e0b3b + c3e8a2f commit 3a7b454

File tree

1 file changed

+3
-3
lines changed
  • staging/src/k8s.io/component-base/metrics

1 file changed

+3
-3
lines changed

staging/src/k8s.io/component-base/metrics/opts.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ func (o *GaugeOpts) annotateStabilityLevel() {
125125

126126
// convenience function to allow easy transformation to the prometheus
127127
// counterpart. This will do more once we have a proper label abstraction
128-
func (o GaugeOpts) toPromGaugeOpts() prometheus.GaugeOpts {
128+
func (o *GaugeOpts) toPromGaugeOpts() prometheus.GaugeOpts {
129129
return prometheus.GaugeOpts{
130130
Namespace: o.Namespace,
131131
Subsystem: o.Subsystem,
@@ -169,7 +169,7 @@ func (o *HistogramOpts) annotateStabilityLevel() {
169169

170170
// convenience function to allow easy transformation to the prometheus
171171
// counterpart. This will do more once we have a proper label abstraction
172-
func (o HistogramOpts) toPromHistogramOpts() prometheus.HistogramOpts {
172+
func (o *HistogramOpts) toPromHistogramOpts() prometheus.HistogramOpts {
173173
return prometheus.HistogramOpts{
174174
Namespace: o.Namespace,
175175
Subsystem: o.Subsystem,
@@ -224,7 +224,7 @@ var (
224224

225225
// convenience function to allow easy transformation to the prometheus
226226
// counterpart. This will do more once we have a proper label abstraction
227-
func (o SummaryOpts) toPromSummaryOpts() prometheus.SummaryOpts {
227+
func (o *SummaryOpts) toPromSummaryOpts() prometheus.SummaryOpts {
228228
// we need to retain existing quantile behavior for backwards compatibility,
229229
// so let's do what prometheus used to do prior to v1.
230230
objectives := o.Objectives

0 commit comments

Comments
 (0)