Merge pull request kubernetes#89981 from gaurav1086/VolumeMode_nil_ptr_check

k8s-ci-robot · web-flow · commit 3c3497bed968 · 2020-04-27T22:26:19.000-07:00
[volume] VolumeMode nil pointer check
diff --git a/pkg/volume/cinder/cinder_block_test.go b/pkg/volume/cinder/cinder_block_test.go
@@ -70,8 +70,8 @@ func TestGetVolumeSpecFromGlobalMapPath(t *testing.T) {
 	}
 	block := v1.PersistentVolumeBlock
 	specMode := spec.PersistentVolume.Spec.VolumeMode
-	if &specMode == nil {
-		t.Errorf("Invalid volumeMode from GlobalMapPath spec: %v expected: %v", &specMode, block)
+	if specMode == nil {
+		t.Fatalf("Failed to get volumeMode from PersistentVolumeBlock")
 	}
 	if *specMode != block {
 		t.Errorf("Invalid volumeMode from GlobalMapPath spec: %v expected: %v", *specMode, block)

Original file line number	Diff line number	Diff line change
`@@ -70,8 +70,8 @@ func TestGetVolumeSpecFromGlobalMapPath(t *testing.T) {`
`70`	`70`	`}`
`71`	`71`	`block := v1.PersistentVolumeBlock`
`72`	`72`	`specMode := spec.PersistentVolume.Spec.VolumeMode`
`73`		`- if &specMode == nil {`
`74`		`- t.Errorf("Invalid volumeMode from GlobalMapPath spec: %v expected: %v", &specMode, block)`
	`73`	`+ if specMode == nil {`
	`74`	`+ t.Fatalf("Failed to get volumeMode from PersistentVolumeBlock")`
`75`	`75`	`}`
`76`	`76`	`if *specMode != block {`
`77`	`77`	`t.Errorf("Invalid volumeMode from GlobalMapPath spec: %v expected: %v", *specMode, block)`