Skip to content

Commit 3c5dad6

Browse files
authored
Merge pull request kubernetes#85494 from yutedz/node-cidr-mask
Fill in default node cidr mask size when dual stack is not enabled
2 parents 9767125 + 5be960c commit 3c5dad6

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

cmd/kubeadm/app/phases/controlplane/manifests.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -315,11 +315,8 @@ func getControllerManagerCommand(cfg *kubeadmapi.ClusterConfiguration) []string
315315
// Let the controller-manager allocate Node CIDRs for the Pod network.
316316
// Each node will get a subspace of the address CIDR provided with --pod-network-cidr.
317317
if cfg.Networking.PodSubnet != "" {
318-
// TODO(Arvinderpal): Needs to be fixed once PR #73977 lands. Should be a list of maskSizes.
319-
maskSize := calcNodeCidrSize(cfg.Networking.PodSubnet)
320318
defaultArguments["allocate-node-cidrs"] = "true"
321319
defaultArguments["cluster-cidr"] = cfg.Networking.PodSubnet
322-
defaultArguments["node-cidr-mask-size"] = maskSize
323320
if cfg.Networking.ServiceSubnet != "" {
324321
defaultArguments["service-cluster-ip-range"] = cfg.Networking.ServiceSubnet
325322
}
@@ -329,6 +326,10 @@ func getControllerManagerCommand(cfg *kubeadmapi.ClusterConfiguration) []string
329326
// Note: The user still retains the ability to explicitly set feature-gates and that value will overwrite this base value.
330327
if enabled, present := cfg.FeatureGates[features.IPv6DualStack]; present {
331328
defaultArguments["feature-gates"] = fmt.Sprintf("%s=%t", features.IPv6DualStack, enabled)
329+
} else if cfg.Networking.PodSubnet != "" {
330+
// TODO(Arvinderpal): Needs to be fixed once PR #73977 lands. Should be a list of maskSizes.
331+
maskSize := calcNodeCidrSize(cfg.Networking.PodSubnet)
332+
defaultArguments["node-cidr-mask-size"] = maskSize
332333
}
333334

334335
command := []string{"kube-controller-manager"}

0 commit comments

Comments
 (0)