Skip to content

Commit 3d78928

Browse files
authored
Merge pull request kubernetes#91563 from SataQiu/fix-kubelet-20200529
Add duration to image pulling event
2 parents bcdb3c5 + f1729b0 commit 3d78928

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/kubelet/images/image_manager.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package images
1818

1919
import (
2020
"fmt"
21+
"time"
2122

2223
dockerref "github.com/docker/distribution/reference"
2324
v1 "k8s.io/api/core/v1"
@@ -138,6 +139,7 @@ func (m *imageManager) EnsureImageExists(pod *v1.Pod, container *v1.Container, p
138139
return "", msg, ErrImagePullBackOff
139140
}
140141
m.logIt(ref, v1.EventTypeNormal, events.PullingImage, logPrefix, fmt.Sprintf("Pulling image %q", container.Image), klog.Info)
142+
startTime := time.Now()
141143
pullChan := make(chan pullResult)
142144
m.puller.pullImage(spec, pullSecrets, pullChan, podSandboxConfig)
143145
imagePullResult := <-pullChan
@@ -151,7 +153,7 @@ func (m *imageManager) EnsureImageExists(pod *v1.Pod, container *v1.Container, p
151153

152154
return "", imagePullResult.err.Error(), ErrImagePull
153155
}
154-
m.logIt(ref, v1.EventTypeNormal, events.PulledImage, logPrefix, fmt.Sprintf("Successfully pulled image %q", container.Image), klog.Info)
156+
m.logIt(ref, v1.EventTypeNormal, events.PulledImage, logPrefix, fmt.Sprintf("Successfully pulled image %q in %v", container.Image, time.Since(startTime)), klog.Info)
155157
m.backOff.GC()
156158
return imagePullResult.imageRef, "", nil
157159
}

0 commit comments

Comments
 (0)