Fix validation message for CSR condition status values

liggitt · liggitt · commit 3f1546960d14 · 2020-06-05T00:50:01.000-04:00
diff --git a/pkg/apis/certificates/validation/validation.go b/pkg/apis/certificates/validation/validation.go
@@ -239,7 +239,7 @@ func validateConditions(fldPath *field.Path, csr *certificates.CertificateSignin
 		case c.Status == "":
 			allErrs = append(allErrs, field.Required(fldPath.Index(i).Child("status"), ""))
 		case !allowedStatusValues.Has(string(c.Status)):
-			allErrs = append(allErrs, field.NotSupported(fldPath.Index(i).Child("status"), c.Status, trueConditionTypes.List()))
+			allErrs = append(allErrs, field.NotSupported(fldPath.Index(i).Child("status"), c.Status, allowedStatusValues.List()))
 		}
 
 		if !opts.allowBothApprovedAndDenied {

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ func validateConditions(fldPath field.Path, csr certificates.CertificateSignin`
`239`	`239`	`case c.Status == "":`
`240`	`240`	`allErrs = append(allErrs, field.Required(fldPath.Index(i).Child("status"), ""))`
`241`	`241`	`case !allowedStatusValues.Has(string(c.Status)):`
`242`		`- allErrs = append(allErrs, field.NotSupported(fldPath.Index(i).Child("status"), c.Status, trueConditionTypes.List()))`
	`242`	`+ allErrs = append(allErrs, field.NotSupported(fldPath.Index(i).Child("status"), c.Status, allowedStatusValues.List()))`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`if !opts.allowBothApprovedAndDenied {`