Skip to content

Commit 3f7e26d

Browse files
authored
Merge pull request kubernetes#95242 from jingxu97/sep/gate
Add gate to install CSI proxy
2 parents add19e4 + d02f3a8 commit 3f7e26d

File tree

4 files changed

+27
-16
lines changed

4 files changed

+27
-16
lines changed

cluster/gce/config-default.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -521,3 +521,6 @@ export GCE_PRIVATE_CLUSTER_PORTS_PER_VM="${KUBE_GCE_PRIVATE_CLUSTER_PORTS_PER_VM
521521
# Optional: Create apiserver konnectivity server and agent.
522522
export ENABLE_EGRESS_VIA_KONNECTIVITY_SERVICE="${KUBE_ENABLE_EGRESS_VIA_KONNECTIVITY_SERVICE:-false}"
523523
export KONNECTIVITY_SERVICE_PROXY_PROTOCOL_MODE="${KUBE_KONNECTIVITY_SERVICE_PROXY_PROTOCOL_MODE:-grpc}"
524+
525+
# Optional: Enable Windows CSI-Proxy
526+
export ENABLE_CSI_PROXY="${ENABLE_CSI_PROXY:-true}"

cluster/gce/config-test.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -568,3 +568,6 @@ export GCE_PRIVATE_CLUSTER_PORTS_PER_VM=${KUBE_GCE_PRIVATE_CLUSTER_PORTS_PER_VM:
568568
export ETCD_LISTEN_CLIENT_IP=0.0.0.0
569569

570570
export GCE_UPLOAD_KUBCONFIG_TO_MASTER_METADATA=true
571+
572+
# Optoinal: Enable Windows CSI-Proxy
573+
export ENABLE_CSI_PROXY="${ENABLE_CSI_PROXY:-true}"

cluster/gce/util.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1530,6 +1530,7 @@ NODE_BINARY_TAR_URL: $(yaml-quote "${NODE_BINARY_TAR_URL}")
15301530
NODE_BINARY_TAR_HASH: $(yaml-quote "${NODE_BINARY_TAR_HASH}")
15311531
CSI_PROXY_STORAGE_PATH: $(yaml-quote "${CSI_PROXY_STORAGE_PATH}")
15321532
CSI_PROXY_VERSION: $(yaml-quote "${CSI_PROXY_VERSION}")
1533+
ENABLE_CSI_PROXY: $(yaml-quote "${ENABLE_CSI_PROXY}")
15331534
K8S_DIR: $(yaml-quote "${WINDOWS_K8S_DIR}")
15341535
NODE_DIR: $(yaml-quote "${WINDOWS_NODE_DIR}")
15351536
LOGS_DIR: $(yaml-quote "${WINDOWS_LOGS_DIR}")

cluster/gce/windows/k8s-node-setup.psm1

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,7 @@ function Set-EnvironmentVars {
263263
"WINDOWS_CNI_VERSION" = ${kube_env}['WINDOWS_CNI_VERSION']
264264
"CSI_PROXY_STORAGE_PATH" = ${kube_env}['CSI_PROXY_STORAGE_PATH']
265265
"CSI_PROXY_VERSION" = ${kube_env}['CSI_PROXY_VERSION']
266+
"ENABLE_CSI_PROXY" = ${kube_env}['ENABLE_CSI_PROXY']
266267
"PKI_DIR" = ${kube_env}['PKI_DIR']
267268
"CA_FILE_PATH" = ${kube_env}['CA_FILE_PATH']
268269
"KUBELET_CONFIG" = ${kube_env}['KUBELET_CONFIG_FILE']
@@ -403,26 +404,29 @@ function DownloadAndInstall-KubernetesBinaries {
403404
# Required ${kube_env} keys:
404405
# CSI_PROXY_STORAGE_PATH and CSI_PROXY_VERSION
405406
function DownloadAndInstall-CSIProxyBinaries {
406-
if (ShouldWrite-File ${env:NODE_DIR}\csi-proxy.exe) {
407-
$tmp_dir = 'C:\k8s_tmp'
408-
New-Item -Force -ItemType 'directory' $tmp_dir | Out-Null
409-
$filename = 'csi-proxy.exe'
410-
$urls = "${env:CSI_PROXY_STORAGE_PATH}/${env:CSI_PROXY_VERSION}/$filename"
411-
MustDownload-File -OutFile $tmp_dir\$filename -URLs $urls
412-
Move-Item -Force $tmp_dir\$filename ${env:NODE_DIR}\$filename
413-
# Clean up the temporary directory
414-
Remove-Item -Force -Recurse $tmp_dir
407+
if ("${env:ENABLE_CSI_PROXY}" -eq "true") {
408+
if (ShouldWrite-File ${env:NODE_DIR}\csi-proxy.exe) {
409+
$tmp_dir = 'C:\k8s_tmp'
410+
New-Item -Force -ItemType 'directory' $tmp_dir | Out-Null
411+
$filename = 'csi-proxy.exe'
412+
$urls = "${env:CSI_PROXY_STORAGE_PATH}/${env:CSI_PROXY_VERSION}/$filename"
413+
MustDownload-File -OutFile $tmp_dir\$filename -URLs $urls
414+
Move-Item -Force $tmp_dir\$filename ${env:NODE_DIR}\$filename
415+
# Clean up the temporary directory
416+
Remove-Item -Force -Recurse $tmp_dir
417+
}
415418
}
416419
}
417420

418421
function Start-CSIProxy {
419-
Log-Output "Creating CSI Proxy Service"
420-
$flags = "-windows-service -log_file=${env:LOGS_DIR}\csi-proxy.log -logtostderr=false"
421-
& sc.exe create csiproxy binPath= "${env:NODE_DIR}\csi-proxy.exe $flags"
422-
& sc.exe failure csiproxy reset= 0 actions= restart/10000
423-
Log-Output "Starting CSI Proxy Service"
424-
& sc.exe start csiproxy
425-
422+
if ("${env:ENABLE_CSI_PROXY}" -eq "true") {
423+
Log-Output "Creating CSI Proxy Service"
424+
$flags = "-windows-service -log_file=${env:LOGS_DIR}\csi-proxy.log -logtostderr=false"
425+
& sc.exe create csiproxy binPath= "${env:NODE_DIR}\csi-proxy.exe $flags"
426+
& sc.exe failure csiproxy reset= 0 actions= restart/10000
427+
Log-Output "Starting CSI Proxy Service"
428+
& sc.exe start csiproxy
429+
}
426430
}
427431

428432
# TODO(pjh): this is copied from

0 commit comments

Comments
 (0)