Skip to content

Commit 40d8019

Browse files
committed
Only check testname for missing
1 parent 90cd496 commit 40d8019

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

test/conformance/walk.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ func commentToConformanceData(comment string) *conformanceData {
329329
descLines = append(descLines, line)
330330
}
331331
}
332-
if cd.Release == "" && cd.TestName == "" {
332+
if cd.TestName == "" {
333333
return nil
334334
}
335335

test/conformance/walk_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,8 @@ func TestCommentToConformanceData(t *testing.T) {
147147
desc: "No Release or Testname leads to nil",
148148
input: "Description: foo",
149149
}, {
150-
desc: "Release but no Testname does not result in nil",
151-
input: "Release: v1.1\nDescription: foo",
152-
expected: &conformanceData{Release: "v1.1", Description: "foo"},
150+
desc: "Release but no Testname should result in nil",
151+
input: "Release: v1.1\nDescription: foo",
153152
}, {
154153
desc: "Testname but no Release does not result in nil",
155154
input: "Testname: mytest\nDescription: foo",

0 commit comments

Comments
 (0)