Skip to content

Commit 4123973

Browse files
committed
e2e: move funs of framework/deployment/fixtures.go to e2e/apps/deployment.go
Signed-off-by: yuxiaobo <[email protected]>
1 parent b632ead commit 4123973

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

test/e2e/apps/deployment.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ func testRolloverDeployment(f *framework.Framework) {
460460
err = e2edeploy.WaitForDeploymentUpdatedReplicasGTE(c, ns, deploymentName, deploymentReplicas, deployment.Generation)
461461
// Check if it's updated to revision 1 correctly
462462
framework.Logf("Check revision of new replica set for deployment %q", deploymentName)
463-
err = e2edeploy.CheckDeploymentRevisionAndImage(c, ns, deploymentName, "1", deploymentImage)
463+
err = checkDeploymentRevisionAndImage(c, ns, deploymentName, "1", deploymentImage)
464464
framework.ExpectNoError(err)
465465

466466
framework.Logf("Ensure that both replica sets have 1 created replica")
@@ -1122,3 +1122,8 @@ func waitForReplicaSetTargetSpecReplicas(c clientset.Interface, replicaSet *apps
11221122
}
11231123
return err
11241124
}
1125+
1126+
// checkDeploymentRevisionAndImage checks if the input deployment's and its new replica set's revision and image are as expected.
1127+
func checkDeploymentRevisionAndImage(c clientset.Interface, ns, deploymentName, revision, image string) error {
1128+
return testutil.CheckDeploymentRevisionAndImage(c, ns, deploymentName, revision, image)
1129+
}

test/e2e/framework/deployment/fixtures.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,6 @@ func UpdateDeploymentWithRetries(c clientset.Interface, namespace, name string,
3535
return testutils.UpdateDeploymentWithRetries(c, namespace, name, applyUpdate, framework.Logf, poll, pollShortTimeout)
3636
}
3737

38-
// CheckDeploymentRevisionAndImage checks if the input deployment's and its new replica set's revision and image are as expected.
39-
func CheckDeploymentRevisionAndImage(c clientset.Interface, ns, deploymentName, revision, image string) error {
40-
return testutils.CheckDeploymentRevisionAndImage(c, ns, deploymentName, revision, image)
41-
}
42-
4338
// NewDeployment returns a deployment spec with the specified argument.
4439
func NewDeployment(deploymentName string, replicas int32, podLabels map[string]string, imageName, image string, strategyType appsv1.DeploymentStrategyType) *appsv1.Deployment {
4540
zero := int64(0)

0 commit comments

Comments
 (0)