Skip to content

Commit 445fc9f

Browse files
authored
Merge pull request kubernetes#76563 from shinytang6/clean-up-scheduler
correct some comments in scheduler code
2 parents 76b877a + 6d11926 commit 445fc9f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

pkg/scheduler/algorithm/predicates/predicates.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,7 @@ func (c *VolumeZoneChecker) predicate(pod *v1.Pod, meta PredicateMetadata, nodeI
687687
}
688688
}
689689
}
690-
return false, nil, fmt.Errorf("PersistentVolumeClaim is not bound: %q", pvcName)
690+
return false, nil, fmt.Errorf("PersistentVolumeClaim was not found: %q", pvcName)
691691
}
692692

693693
pv, err := c.pvInfo.GetPersistentVolumeInfo(pvName)
@@ -696,7 +696,7 @@ func (c *VolumeZoneChecker) predicate(pod *v1.Pod, meta PredicateMetadata, nodeI
696696
}
697697

698698
if pv == nil {
699-
return false, nil, fmt.Errorf("PersistentVolume not found: %q", pvName)
699+
return false, nil, fmt.Errorf("PersistentVolume was not found: %q", pvName)
700700
}
701701

702702
for k, v := range pv.ObjectMeta.Labels {

pkg/scheduler/algorithmprovider/defaults/defaults.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,13 @@ func defaultPredicates() sets.String {
5959
// ApplyFeatureGates applies algorithm by feature gates.
6060
func ApplyFeatureGates() {
6161
if utilfeature.DefaultFeatureGate.Enabled(features.TaintNodesByCondition) {
62-
// Remove "CheckNodeCondition", "CheckNodeMemoryPressure", "CheckNodePIDPressurePred"
62+
// Remove "CheckNodeCondition", "CheckNodeMemoryPressure", "CheckNodePIDPressure"
6363
// and "CheckNodeDiskPressure" predicates
6464
factory.RemoveFitPredicate(predicates.CheckNodeConditionPred)
6565
factory.RemoveFitPredicate(predicates.CheckNodeMemoryPressurePred)
6666
factory.RemoveFitPredicate(predicates.CheckNodeDiskPressurePred)
6767
factory.RemoveFitPredicate(predicates.CheckNodePIDPressurePred)
68-
// Remove key "CheckNodeCondition", "CheckNodeMemoryPressure" and "CheckNodeDiskPressure"
68+
// Remove key "CheckNodeCondition", "CheckNodeMemoryPressure", "CheckNodePIDPressure" and "CheckNodeDiskPressure"
6969
// from ALL algorithm provider
7070
// The key will be removed from all providers which in algorithmProviderMap[]
7171
// if you just want remove specific provider, call func RemovePredicateKeyFromAlgoProvider()

0 commit comments

Comments
 (0)