Skip to content

Commit 46c8b07

Browse files
authored
Merge pull request kubernetes#76025 from neolit123/fix-panic-apps-daemon-set
test/e2e/apps: fix panic in DaemonSet tests due to legacy scheme
2 parents d7d852a + 405f9eb commit 46c8b07

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

test/e2e/apps/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ go_library(
2323
],
2424
importpath = "k8s.io/kubernetes/test/e2e/apps",
2525
deps = [
26-
"//pkg/api/legacyscheme:go_default_library",
2726
"//pkg/api/v1/pod:go_default_library",
2827
"//pkg/apis/apps:go_default_library",
2928
"//pkg/apis/batch:go_default_library",

test/e2e/apps/daemon_set.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import (
3131
"k8s.io/apimachinery/pkg/types"
3232
"k8s.io/apimachinery/pkg/util/wait"
3333
clientset "k8s.io/client-go/kubernetes"
34-
"k8s.io/kubernetes/pkg/api/legacyscheme"
34+
"k8s.io/client-go/kubernetes/scheme"
3535
podutil "k8s.io/kubernetes/pkg/api/v1/pod"
3636
extensionsinternal "k8s.io/kubernetes/pkg/apis/extensions"
3737
"k8s.io/kubernetes/pkg/controller/daemon"
@@ -78,12 +78,12 @@ var _ = SIGDescribe("Daemon set [Serial]", func() {
7878
}
7979
}
8080
if daemonsets, err := f.ClientSet.AppsV1().DaemonSets(f.Namespace.Name).List(metav1.ListOptions{}); err == nil {
81-
framework.Logf("daemonset: %s", runtime.EncodeOrDie(legacyscheme.Codecs.LegacyCodec(legacyscheme.Scheme.PrioritizedVersionsAllGroups()...), daemonsets))
81+
framework.Logf("daemonset: %s", runtime.EncodeOrDie(scheme.Codecs.LegacyCodec(scheme.Scheme.PrioritizedVersionsAllGroups()...), daemonsets))
8282
} else {
8383
framework.Logf("unable to dump daemonsets: %v", err)
8484
}
8585
if pods, err := f.ClientSet.CoreV1().Pods(f.Namespace.Name).List(metav1.ListOptions{}); err == nil {
86-
framework.Logf("pods: %s", runtime.EncodeOrDie(legacyscheme.Codecs.LegacyCodec(legacyscheme.Scheme.PrioritizedVersionsAllGroups()...), pods))
86+
framework.Logf("pods: %s", runtime.EncodeOrDie(scheme.Codecs.LegacyCodec(scheme.Scheme.PrioritizedVersionsAllGroups()...), pods))
8787
} else {
8888
framework.Logf("unable to dump pods: %v", err)
8989
}

0 commit comments

Comments
 (0)