Skip to content

Commit 472a4e9

Browse files
authored
Merge pull request kubernetes#91448 from RainbowMango/pr_fix_metric_naming
update metrics to conform promlint
2 parents 2572066 + 4d8280a commit 472a4e9

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

pkg/scheduler/metrics/metrics.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ var (
145145
PreemptionAttempts = metrics.NewCounter(
146146
&metrics.CounterOpts{
147147
Subsystem: SchedulerSubsystem,
148-
Name: "total_preemption_attempts",
148+
Name: "preemption_attempts_total",
149149
Help: "Total preemption attempts in the cluster till now",
150150
StabilityLevel: metrics.ALPHA,
151151
})

staging/src/k8s.io/component-base/metrics/testutil/promlint.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,6 @@ var exceptionMetrics = []string{
5353
// kube-proxy
5454
"kubernetes_build_info",
5555

56-
// kube-scheduler
57-
"scheduler_total_preemption_attempts",
58-
5956
// kubelet-resource-v1alpha1
6057
"container_cpu_usage_seconds_total",
6158
"node_cpu_usage_seconds_total",

0 commit comments

Comments
 (0)