Skip to content

Commit 4763720

Browse files
authored
Merge pull request kubernetes#74338 from BenTheElder/testcmdshellcheck
make test/cmd/delete.sh pass shellcheck
2 parents 739af85 + da859ae commit 4763720

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

hack/.shellcheck_failures

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@
133133
./test/cmd/core.sh
134134
./test/cmd/crd.sh
135135
./test/cmd/create.sh
136-
./test/cmd/delete.sh
137136
./test/cmd/diff.sh
138137
./test/cmd/discovery.sh
139138
./test/cmd/generic-resources.sh

test/cmd/delete.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ run_kubectl_delete_allnamespaces_tests() {
3636

3737
# no configmaps should be in either of those namespaces
3838
kubectl config set-context "${CONTEXT}" --namespace="${ns_one}"
39-
kube::test::get_object_assert configmap "{{range.items}}{{$id_field}}:{{end}}" ''
39+
kube::test::get_object_assert configmap "{{range.items}}{{${id_field:?}}}:{{end}}" ''
4040
kubectl config set-context "${CONTEXT}" --namespace="${ns_two}"
41-
kube::test::get_object_assert configmap "{{range.items}}{{$id_field}}:{{end}}" ''
41+
kube::test::get_object_assert configmap "{{range.items}}{{${id_field:?}}}:{{end}}" ''
4242

4343
set +o nounset
4444
set +o errexit

0 commit comments

Comments
 (0)