Skip to content

Commit 4abd730

Browse files
committed
Do one more level of casting to get the 'assumeCache'
1 parent 3315474 commit 4abd730

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

pkg/controller/volume/scheduling/scheduler_assume_cache.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ type PVAssumeCache interface {
345345
}
346346

347347
type pvAssumeCache struct {
348-
*assumeCache
348+
AssumeCache
349349
}
350350

351351
func pvStorageClassIndexFunc(obj interface{}) ([]string, error) {
@@ -357,7 +357,7 @@ func pvStorageClassIndexFunc(obj interface{}) ([]string, error) {
357357

358358
// NewPVAssumeCache creates a PV assume cache.
359359
func NewPVAssumeCache(informer cache.SharedIndexInformer) PVAssumeCache {
360-
return &pvAssumeCache{NewAssumeCache(informer, "v1.PersistentVolume", "storageclass", pvStorageClassIndexFunc).(*assumeCache)}
360+
return &pvAssumeCache{NewAssumeCache(informer, "v1.PersistentVolume", "storageclass", pvStorageClassIndexFunc)}
361361
}
362362

363363
func (c *pvAssumeCache) GetPV(pvName string) (*v1.PersistentVolume, error) {
@@ -413,12 +413,12 @@ type PVCAssumeCache interface {
413413
}
414414

415415
type pvcAssumeCache struct {
416-
*assumeCache
416+
AssumeCache
417417
}
418418

419419
// NewPVCAssumeCache creates a PVC assume cache.
420420
func NewPVCAssumeCache(informer cache.SharedIndexInformer) PVCAssumeCache {
421-
return &pvcAssumeCache{NewAssumeCache(informer, "v1.PersistentVolumeClaim", "namespace", cache.MetaNamespaceIndexFunc).(*assumeCache)}
421+
return &pvcAssumeCache{NewAssumeCache(informer, "v1.PersistentVolumeClaim", "namespace", cache.MetaNamespaceIndexFunc)}
422422
}
423423

424424
func (c *pvcAssumeCache) GetPVC(pvcKey string) (*v1.PersistentVolumeClaim, error) {

pkg/controller/volume/scheduling/scheduler_assume_cache_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ func TestAssumePV(t *testing.T) {
109109

110110
for name, scenario := range scenarios {
111111
cache := NewPVAssumeCache(nil)
112-
internalCache, ok := cache.(*pvAssumeCache)
112+
internalCache, ok := cache.(*pvAssumeCache).AssumeCache.(*assumeCache)
113113
if !ok {
114114
t.Fatalf("Failed to get internal cache")
115115
}
@@ -143,7 +143,7 @@ func TestAssumePV(t *testing.T) {
143143

144144
func TestRestorePV(t *testing.T) {
145145
cache := NewPVAssumeCache(nil)
146-
internalCache, ok := cache.(*pvAssumeCache)
146+
internalCache, ok := cache.(*pvAssumeCache).AssumeCache.(*assumeCache)
147147
if !ok {
148148
t.Fatalf("Failed to get internal cache")
149149
}
@@ -183,7 +183,7 @@ func TestRestorePV(t *testing.T) {
183183

184184
func TestBasicPVCache(t *testing.T) {
185185
cache := NewPVAssumeCache(nil)
186-
internalCache, ok := cache.(*pvAssumeCache)
186+
internalCache, ok := cache.(*pvAssumeCache).AssumeCache.(*assumeCache)
187187
if !ok {
188188
t.Fatalf("Failed to get internal cache")
189189
}
@@ -227,7 +227,7 @@ func TestBasicPVCache(t *testing.T) {
227227

228228
func TestPVCacheWithStorageClasses(t *testing.T) {
229229
cache := NewPVAssumeCache(nil)
230-
internalCache, ok := cache.(*pvAssumeCache)
230+
internalCache, ok := cache.(*pvAssumeCache).AssumeCache.(*assumeCache)
231231
if !ok {
232232
t.Fatalf("Failed to get internal cache")
233233
}
@@ -273,7 +273,7 @@ func TestPVCacheWithStorageClasses(t *testing.T) {
273273

274274
func TestAssumeUpdatePVCache(t *testing.T) {
275275
cache := NewPVAssumeCache(nil)
276-
internalCache, ok := cache.(*pvAssumeCache)
276+
internalCache, ok := cache.(*pvAssumeCache).AssumeCache.(*assumeCache)
277277
if !ok {
278278
t.Fatalf("Failed to get internal cache")
279279
}
@@ -366,7 +366,7 @@ func TestAssumePVC(t *testing.T) {
366366

367367
for name, scenario := range scenarios {
368368
cache := NewPVCAssumeCache(nil)
369-
internalCache, ok := cache.(*pvcAssumeCache)
369+
internalCache, ok := cache.(*pvcAssumeCache).AssumeCache.(*assumeCache)
370370
if !ok {
371371
t.Fatalf("Failed to get internal cache")
372372
}
@@ -400,7 +400,7 @@ func TestAssumePVC(t *testing.T) {
400400

401401
func TestRestorePVC(t *testing.T) {
402402
cache := NewPVCAssumeCache(nil)
403-
internalCache, ok := cache.(*pvcAssumeCache)
403+
internalCache, ok := cache.(*pvcAssumeCache).AssumeCache.(*assumeCache)
404404
if !ok {
405405
t.Fatalf("Failed to get internal cache")
406406
}
@@ -440,7 +440,7 @@ func TestRestorePVC(t *testing.T) {
440440

441441
func TestAssumeUpdatePVCCache(t *testing.T) {
442442
cache := NewPVCAssumeCache(nil)
443-
internalCache, ok := cache.(*pvcAssumeCache)
443+
internalCache, ok := cache.(*pvcAssumeCache).AssumeCache.(*assumeCache)
444444
if !ok {
445445
t.Fatalf("Failed to get internal cache")
446446
}

pkg/controller/volume/scheduling/scheduler_binder_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ type testEnv struct {
103103
binder SchedulerVolumeBinder
104104
internalBinder *volumeBinder
105105
internalNodeInformer coreinformers.NodeInformer
106-
internalPVCache *pvAssumeCache
107-
internalPVCCache *pvcAssumeCache
106+
internalPVCache *assumeCache
107+
internalPVCCache *assumeCache
108108
}
109109

110110
func newTestBinder(t *testing.T, stopCh <-chan struct{}) *testEnv {
@@ -206,13 +206,13 @@ func newTestBinder(t *testing.T, stopCh <-chan struct{}) *testEnv {
206206
}
207207

208208
pvCache := internalBinder.pvCache
209-
internalPVCache, ok := pvCache.(*pvAssumeCache)
209+
internalPVCache, ok := pvCache.(*pvAssumeCache).AssumeCache.(*assumeCache)
210210
if !ok {
211211
t.Fatalf("Failed to convert to internal PV cache")
212212
}
213213

214214
pvcCache := internalBinder.pvcCache
215-
internalPVCCache, ok := pvcCache.(*pvcAssumeCache)
215+
internalPVCCache, ok := pvcCache.(*pvcAssumeCache).AssumeCache.(*assumeCache)
216216
if !ok {
217217
t.Fatalf("Failed to convert to internal PVC cache")
218218
}

0 commit comments

Comments
 (0)