Merge pull request kubernetes#87355 from mattjmcnaughton/mattjmcnaughton/remove-unnecessary-sudo-from-e2e

k8s-ci-robot · web-flow · commit 4e8a7f4a4b0c · 2020-02-14T06:10:17.000-08:00
Clean up TODO around running test as sudo
diff --git a/test/e2e_node/apparmor_test.go b/test/e2e_node/apparmor_test.go
@@ -125,8 +125,7 @@ func loadTestProfiles() error {
 		return fmt.Errorf("failed to write profiles to file: %v", err)
 	}
 
-	// TODO(random-liu): The test is run as root now, no need to use sudo here.
-	cmd := exec.Command("sudo", "apparmor_parser", "-r", "-W", f.Name())
+	cmd := exec.Command("apparmor_parser", "-r", "-W", f.Name())
 	stderr := &bytes.Buffer{}
 	cmd.Stderr = stderr
 	out, err := cmd.Output()

Original file line number	Diff line number	Diff line change
`@@ -125,8 +125,7 @@ func loadTestProfiles() error {`
`125`	`125`	`return fmt.Errorf("failed to write profiles to file: %v", err)`
`126`	`126`	`}`
`127`	`127`
`128`		`- // TODO(random-liu): The test is run as root now, no need to use sudo here.`
`129`		`- cmd := exec.Command("sudo", "apparmor_parser", "-r", "-W", f.Name())`
	`128`	`+ cmd := exec.Command("apparmor_parser", "-r", "-W", f.Name())`
`130`	`129`	`stderr := &bytes.Buffer{}`
`131`	`130`	`cmd.Stderr = stderr`
`132`	`131`	`out, err := cmd.Output()`