Skip to content

Commit 4f15c01

Browse files
authored
Merge pull request kubernetes#80657 from rphillips/fixes/log_metrics_add_uid
kubelet: add UID to kubelet_container_log_filesystem_used_bytes metric
2 parents 6e85da0 + 2bdf975 commit 4f15c01

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

pkg/kubelet/metrics/collectors/log_metrics.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ var (
2828
"kubelet_container_log_filesystem_used_bytes",
2929
"Bytes used by the container's logs on the filesystem.",
3030
[]string{
31+
"uid",
3132
"namespace",
3233
"pod",
3334
"container",
@@ -67,6 +68,7 @@ func (c *logMetricsCollector) Collect(ch chan<- prometheus.Metric) {
6768
descLogSize,
6869
prometheus.GaugeValue,
6970
float64(*c.Logs.UsedBytes),
71+
ps.PodRef.UID,
7072
ps.PodRef.Namespace,
7173
ps.PodRef.Name,
7274
c.Name,

pkg/kubelet/metrics/collectors/log_metrics_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ func TestMetricsCollected(t *testing.T) {
5151
PodRef: statsapi.PodReference{
5252
Namespace: "some-namespace",
5353
Name: "podName1",
54+
UID: "UID_some_id",
5455
},
5556
Containers: []statsapi.ContainerStats{
5657
{
@@ -68,7 +69,7 @@ func TestMetricsCollected(t *testing.T) {
6869
err := testutil.CollectAndCompare(collector, strings.NewReader(`
6970
# HELP kubelet_container_log_filesystem_used_bytes Bytes used by the container's logs on the filesystem.
7071
# TYPE kubelet_container_log_filesystem_used_bytes gauge
71-
kubelet_container_log_filesystem_used_bytes{container="containerName1",namespace="some-namespace",pod="podName1"} 18
72+
kubelet_container_log_filesystem_used_bytes{container="containerName1",namespace="some-namespace",pod="podName1",uid="UID_some_id"} 18
7273
`), "kubelet_container_log_filesystem_used_bytes")
7374
if err != nil {
7475
t.Fatal(err)

0 commit comments

Comments
 (0)