Skip to content

Commit 534051a

Browse files
authored
Merge pull request kubernetes#84036 from Huang-Wei/tbe-int-test-issue
Ensure TaintBasedEviction int test not rely on TaintNodeByConditions
2 parents 4887b0c + fbcc3c1 commit 534051a

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

test/integration/scheduler/taint_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -689,7 +689,7 @@ func TestTaintBasedEvictions(t *testing.T) {
689689
0.55, // Unhealthy zone threshold
690690
true, // Run taint manager
691691
true, // Use taint based evictions
692-
false, // Enabled TaintNodeByCondition feature
692+
true, // Enabled TaintNodeByCondition feature
693693
)
694694
if err != nil {
695695
t.Errorf("Failed to create node controller: %v", err)

test/integration/scheduler/util.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,8 @@ func nodeTainted(cs clientset.Interface, nodeName string, taints []v1.Taint) wai
385385
return false, err
386386
}
387387

388-
if len(taints) != len(node.Spec.Taints) {
388+
// node.Spec.Taints may have more taints
389+
if len(taints) > len(node.Spec.Taints) {
389390
return false, nil
390391
}
391392

0 commit comments

Comments
 (0)