Skip to content

Commit 53a394e

Browse files
authored
Merge pull request kubernetes#87188 from claudiubelu/test-images/centralization-cleanup
test images: Image Promoter fixes
2 parents f409793 + 4c51eb9 commit 53a394e

File tree

9 files changed

+10
-29
lines changed

9 files changed

+10
-29
lines changed

hack/lib/util.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,10 @@ function kube::util::ensure_dockerized {
698698
# SED: The name of the gnu-sed binary
699699
#
700700
function kube::util::ensure-gnu-sed {
701-
if LANG=C sed --help 2>&1 | grep -q GNU; then
701+
# NOTE: the echo below is a workaround to ensure sed is executed before the grep.
702+
# see: https://github.com/kubernetes/kubernetes/issues/87251
703+
sed_help="$(LANG=C sed --help 2>&1)"
704+
if echo "${sed_help}" | grep -q "GNU\|BusyBox"; then
702705
SED="sed"
703706
elif command -v gsed &>/dev/null; then
704707
SED="gsed"

test/images/image-util.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ TASK=$1
2222
WHAT=$2
2323

2424
KUBE_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd -P)"
25+
source "${KUBE_ROOT}/hack/lib/logging.sh"
2526
source "${KUBE_ROOT}/hack/lib/util.sh"
2627

2728
# Mapping of go ARCH to actual architectures shipped part of multiarch/qemu-user-static project
@@ -166,8 +167,7 @@ if [[ "${WHAT}" == "all-conformance" ]]; then
166167
# Discussed during Conformance Office Hours Meeting (2019.12.17):
167168
# https://docs.google.com/document/d/1W31nXh9RYAb_VaYkwuPLd1hFxuRX3iU0DmaQ4lkCsX8/edit#heading=h.l87lu17xm9bh
168169
# echoserver image not included: https://github.com/kubernetes/kubernetes/issues/84158
169-
conformance_images=("agnhost" "dnsutils" "jessie-dnsutils" "kitten" "mounttest" "mounttest-user"\
170-
"nautilus" "nonewprivs" "resource-consumer" "resource-consumer-controller" "sample-apiserver" "test-webserver")
170+
conformance_images=("agnhost" "jessie-dnsutils" "kitten" "nautilus" "nonewprivs" "resource-consumer" "sample-apiserver")
171171
for image in "${conformance_images[@]}"; do
172172
eval "${TASK}" "${image}"
173173
done
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.1
1+
1.2

test/images/mounttest-user/BASEIMAGE

Lines changed: 0 additions & 5 deletions
This file was deleted.

test/images/mounttest-user/Dockerfile

Lines changed: 0 additions & 16 deletions
This file was deleted.

test/images/mounttest-user/VERSION

Lines changed: 0 additions & 1 deletion
This file was deleted.

test/images/nonewprivs/VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.0
1+
1.1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.5
1+
1.6
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.17
1+
1.17.2

0 commit comments

Comments
 (0)