Skip to content

Commit 53df13a

Browse files
committed
Uses the resource-consumer/controller image instead of resource-consumer-controller
Dockerhub does not support slashes in the image names, so when the tests are configured to use a dockerhub registry instead of the current gcr.io/kubernetes-e2e-test-images registry, the tests using the mentioned image will fail, as the image cannot exist and cannot be pulled.
1 parent bf4e93d commit 53df13a

File tree

9 files changed

+5
-5
lines changed

9 files changed

+5
-5
lines changed

test/images/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ filegroup(
3131
"//test/images/port-forward-tester:all-srcs",
3232
"//test/images/porter:all-srcs",
3333
"//test/images/resource-consumer:all-srcs",
34+
"//test/images/resource-consumer-controller:all-srcs",
3435
"//test/images/sample-apiserver:all-srcs",
3536
"//test/images/sample-device-plugin:all-srcs",
3637
"//test/images/serve-hostname:all-srcs",
File renamed without changes.

test/images/resource-consumer/controller/BUILD renamed to test/images/resource-consumer-controller/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ go_binary(
1414
go_library(
1515
name = "go_default_library",
1616
srcs = ["controller.go"],
17-
importpath = "k8s.io/kubernetes/test/images/resource-consumer/controller",
17+
importpath = "k8s.io/kubernetes/test/images/resource-consumer-controller",
1818
deps = ["//test/images/resource-consumer/common:go_default_library"],
1919
)
2020

File renamed without changes.

test/images/resource-consumer/controller/Makefile renamed to test/images/resource-consumer-controller/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ SRCS=controller
1616
ARCH ?= amd64
1717
TARGET ?= $(CURDIR)
1818
GOLANG_VERSION ?= latest
19-
SRC_DIR = resource-consumer/$(notdir $(shell pwd))
19+
SRC_DIR = $(notdir $(shell pwd))
2020
export
2121

2222
bin:
23-
../../image-util.sh bin $(SRCS)
23+
../image-util.sh bin $(SRCS)
2424

2525
.PHONY: bin
File renamed without changes.
File renamed without changes.

test/images/resource-consumer/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ filegroup(
3535
":package-srcs",
3636
"//test/images/resource-consumer/common:all-srcs",
3737
"//test/images/resource-consumer/consume-cpu:all-srcs",
38-
"//test/images/resource-consumer/controller:all-srcs",
3938
],
4039
tags = ["automanaged"],
4140
)

test/utils/image/manifest.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ func initImageConfigs() map[int]Config {
234234
configs[PortForwardTester] = Config{e2eRegistry, "port-forward-tester", "1.0"}
235235
configs[Redis] = Config{e2eRegistry, "redis", "1.0"}
236236
configs[ResourceConsumer] = Config{e2eRegistry, "resource-consumer", "1.5"}
237-
configs[ResourceController] = Config{e2eRegistry, "resource-consumer/controller", "1.0"}
237+
configs[ResourceController] = Config{e2eRegistry, "resource-consumer-controller", "1.0"}
238238
configs[ServeHostname] = Config{e2eRegistry, "serve-hostname", "1.1"}
239239
configs[TestWebserver] = Config{e2eRegistry, "test-webserver", "1.0"}
240240
configs[VolumeNFSServer] = Config{e2eRegistry, "volume/nfs", "1.0"}

0 commit comments

Comments
 (0)