Skip to content

Commit 5518def

Browse files
author
Bob Killen
committed
Fix shellcheck lint errors in test/images/volume/nfs/run_nfs.sh
1 parent f795e22 commit 5518def

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

hack/.shellcheck_failures

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,4 +86,3 @@
8686
./test/e2e_node/environment/setup_host.sh
8787
./test/e2e_node/gubernator.sh
8888
./test/images/image-util.sh
89-
./test/images/volume/nfs/run_nfs.sh

test/images/volume/nfs/run_nfs.sh

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,22 @@ function start()
2222
while getopts "G:" opt; do
2323
case ${opt} in
2424
G) gid=${OPTARG};;
25+
*):;;
2526
esac
2627
done
27-
shift $(($OPTIND - 1))
28+
shift $((OPTIND - 1))
2829

2930
# prepare /etc/exports
3031
for i in "$@"; do
3132
# fsid=0: needed for NFSv4
3233
echo "$i *(rw,fsid=0,insecure,no_root_squash)" >> /etc/exports
3334
if [ -v gid ] ; then
34-
chmod 070 $i
35-
chgrp $gid $i
35+
chmod 070 "$i"
36+
chgrp "$gid" "$i"
3637
fi
3738
# move index.html to here
38-
/bin/cp /tmp/index.html $i/
39-
chmod 644 $i/index.html
39+
/bin/cp /tmp/index.html "$i/"
40+
chmod 644 "$i/index.html"
4041
echo "Serving $i"
4142
done
4243

@@ -67,7 +68,7 @@ function stop()
6768
/usr/sbin/exportfs -au
6869
/usr/sbin/exportfs -f
6970

70-
kill $( pidof rpc.mountd )
71+
kill "$( pidof rpc.mountd )"
7172
umount /proc/fs/nfsd
7273
echo > /etc/exports
7374
exit 0

0 commit comments

Comments
 (0)