Skip to content

Commit 55292cf

Browse files
committed
service controller: remove pkg/controller dep in unit tests
Signed-off-by: Andrew Sy Kim <[email protected]>
1 parent 9b44fa4 commit 55292cf

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

pkg/controller/service/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ go_test(
3636
srcs = ["controller_test.go"],
3737
embed = [":go_default_library"],
3838
deps = [
39-
"//pkg/controller:go_default_library",
4039
"//staging/src/k8s.io/api/core/v1:go_default_library",
4140
"//staging/src/k8s.io/apimachinery/pkg/api/errors:go_default_library",
4241
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",

pkg/controller/service/controller_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ import (
4141
fakecloud "k8s.io/cloud-provider/fake"
4242
servicehelper "k8s.io/cloud-provider/service/helpers"
4343
featuregatetesting "k8s.io/component-base/featuregate/testing"
44-
45-
"k8s.io/kubernetes/pkg/controller"
4644
)
4745

4846
const region = "us-central"
@@ -74,7 +72,7 @@ func newController() (*Controller, *fakecloud.Cloud, *fake.Clientset) {
7472

7573
client := fake.NewSimpleClientset()
7674

77-
informerFactory := informers.NewSharedInformerFactory(client, controller.NoResyncPeriodFunc())
75+
informerFactory := informers.NewSharedInformerFactory(client, 0)
7876
serviceInformer := informerFactory.Core().V1().Services()
7977
nodeInformer := informerFactory.Core().V1().Nodes()
8078

0 commit comments

Comments
 (0)