Merge pull request kubernetes#91470 from MHBauer/fail-0-remote-images

k8s-ci-robot · web-flow · commit 5592b5d67a5c · 2020-06-01T20:58:14.000-07:00
explicitly fail if no images are found when running remote tests
diff --git a/test/e2e_node/runner/remote/run_remote.go b/test/e2e_node/runner/remote/run_remote.go
@@ -244,6 +244,10 @@ func main() {
 					klog.Fatalf("Could not retrieve list of images based on image prefix %q and family %q: %v",
 						imageConfig.ImageRegex, imageConfig.ImageFamily, err)
 				}
+				if len(images) == 0 { // if we have no images we can't run anything
+					klog.Fatalf("No matching images retrieved on image prefix %q and family %q: %v",
+						imageConfig.ImageRegex, imageConfig.ImageFamily, err)
+				}
 			} else {
 				images = []string{imageConfig.Image}
 			}

Original file line number	Diff line number	Diff line change
`@@ -244,6 +244,10 @@ func main() {`
`244`	`244`	`klog.Fatalf("Could not retrieve list of images based on image prefix %q and family %q: %v",`
`245`	`245`	`imageConfig.ImageRegex, imageConfig.ImageFamily, err)`
`246`	`246`	`}`
	`247`	`+ if len(images) == 0 { // if we have no images we can't run anything`
	`248`	`+ klog.Fatalf("No matching images retrieved on image prefix %q and family %q: %v",`
	`249`	`+ imageConfig.ImageRegex, imageConfig.ImageFamily, err)`
	`250`	`+ }`
`247`	`251`	`} else {`
`248`	`252`	`images = []string{imageConfig.Image}`
`249`	`253`	`}`