Skip to content

Commit 55b692f

Browse files
authored
Merge pull request kubernetes#86661 from yuxiaobo96/e2e-cleanup-replicaset
e2e:remove func of framework/replicaset to e2e/upgrades/apps/replicas…
2 parents b765dd9 + 572c81f commit 55b692f

File tree

3 files changed

+36
-60
lines changed

3 files changed

+36
-60
lines changed

test/e2e/framework/replicaset/BUILD

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,13 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library")
33
go_library(
44
name = "go_default_library",
55
srcs = [
6-
"fixtures.go",
76
"rest.go",
87
"wait.go",
98
],
109
importpath = "k8s.io/kubernetes/test/e2e/framework/replicaset",
1110
visibility = ["//visibility:public"],
1211
deps = [
1312
"//staging/src/k8s.io/api/apps/v1:go_default_library",
14-
"//staging/src/k8s.io/api/core/v1:go_default_library",
1513
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
1614
"//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library",
1715
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",

test/e2e/framework/replicaset/fixtures.go

Lines changed: 0 additions & 57 deletions
This file was deleted.

test/e2e/upgrades/apps/replicasets.go

Lines changed: 36 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"time"
2222

2323
appsv1 "k8s.io/api/apps/v1"
24+
v1 "k8s.io/api/core/v1"
2425
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2526
"k8s.io/apimachinery/pkg/types"
2627
"k8s.io/kubernetes/test/e2e/framework"
@@ -56,7 +57,7 @@ func (r *ReplicaSetUpgradeTest) Setup(f *framework.Framework) {
5657
nginxImage := imageutils.GetE2EImage(imageutils.Nginx)
5758

5859
ginkgo.By(fmt.Sprintf("Creating replicaset %s in namespace %s", rsName, ns))
59-
replicaSet := replicaset.NewReplicaSet(rsName, ns, 1, map[string]string{"test": "upgrade"}, "nginx", nginxImage)
60+
replicaSet := newReplicaSet(rsName, ns, 1, map[string]string{"test": "upgrade"}, "nginx", nginxImage)
6061
rs, err := c.AppsV1().ReplicaSets(ns).Create(replicaSet)
6162
framework.ExpectNoError(err)
6263

@@ -102,3 +103,37 @@ func (r *ReplicaSetUpgradeTest) Test(f *framework.Framework, done <-chan struct{
102103
func (r *ReplicaSetUpgradeTest) Teardown(f *framework.Framework) {
103104
// rely on the namespace deletion to clean up everything
104105
}
106+
107+
// newReplicaSet returns a new ReplicaSet.
108+
func newReplicaSet(name, namespace string, replicas int32, podLabels map[string]string, imageName, image string) *appsv1.ReplicaSet {
109+
return &appsv1.ReplicaSet{
110+
TypeMeta: metav1.TypeMeta{
111+
Kind: "ReplicaSet",
112+
APIVersion: "apps/v1",
113+
},
114+
ObjectMeta: metav1.ObjectMeta{
115+
Namespace: namespace,
116+
Name: name,
117+
},
118+
Spec: appsv1.ReplicaSetSpec{
119+
Selector: &metav1.LabelSelector{
120+
MatchLabels: podLabels,
121+
},
122+
Replicas: &replicas,
123+
Template: v1.PodTemplateSpec{
124+
ObjectMeta: metav1.ObjectMeta{
125+
Labels: podLabels,
126+
},
127+
Spec: v1.PodSpec{
128+
Containers: []v1.Container{
129+
{
130+
Name: imageName,
131+
Image: image,
132+
SecurityContext: &v1.SecurityContext{},
133+
},
134+
},
135+
},
136+
},
137+
},
138+
}
139+
}

0 commit comments

Comments
 (0)