Skip to content

Commit 56b140c

Browse files
authored
Merge pull request kubernetes#87272 from hase1128/add-comment-to-several-verify-scripts
Add comments in several hack/verify-*.sh
2 parents 9519d97 + e1eabf8 commit 56b140c

9 files changed

+33
-3
lines changed

hack/verify-all.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17-
# This script is a vestigial redirection. Please do not add "real" logic.
17+
# This script runs all the verify scripts respectively, so we should run
18+
# `hack/verify-all.sh` before submit a PR. It is equivalent to `make verify`.
19+
# Usage: `hack/verify-all.sh` or `make verify`.
20+
# Note: This script is a vestigial redirection. Please do not add "real" logic.
1821

1922
set -o errexit
2023
set -o nounset

hack/verify-api-groups.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17-
# locate all API groups by their packages and versions
18-
17+
# This scripts locates all API groups by their packages and versions
18+
# Usage: `hack/verify-api-groups.sh`.
1919

2020
set -o errexit
2121
set -o nounset

hack/verify-bazel.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@
1313
# See the License for the specific language governing permissions and
1414
# limitations under the License.
1515

16+
# This script checks whether updating of the bazel compilation files is needed
17+
# or not. We should run `hack/update-bazel.sh` if actually updates them.
18+
# Usage: `hack/verify-bazel.sh`.
19+
1620
set -o errexit
1721
set -o nounset
1822
set -o pipefail

hack/verify-boilerplate.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17+
# This script checks boilerplate header for all files.
18+
# Usage: `hack/verify-boilerplate.sh`.
19+
1720
set -o errexit
1821
set -o nounset
1922
set -o pipefail

hack/verify-cli-conventions.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17+
# This script checks the description format of help message of kubectl command
18+
# is valid or not. And this checking is done for all kubectl sub-commands.
19+
# Usage: `hack/verify-cli-conventions.sh`.
20+
1721
set -o errexit
1822
set -o nounset
1923
set -o pipefail

hack/verify-codegen.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17+
# This script verifies whether code update is needed or not against the
18+
# specific sub-projects. The sub-projects are listed below this script(the
19+
# line that starts with `CODEGEN_PKG`).
20+
# Usage: `hack/verify-codegen.sh`.
21+
1722
set -o errexit
1823
set -o nounset
1924
set -o pipefail

hack/verify-conformance-requirements.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17+
# This script checks conformance tests follow the requirements as
18+
# https://git.k8s.io/community/contributors/devel/sig-architecture/conformance-tests.md#conformance-test-requirements
19+
# Usage: `hack/verify-conformance-requirements.sh`.
20+
1721
set -o errexit
1822
set -o nounset
1923
set -o pipefail

hack/verify-description.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17+
# This script checks API-related files for missing descriptions and outputs a
18+
# list of structs and fields that are missing descriptions.
19+
# Usage: `hack/verify-description.sh`.
20+
1721
set -o errexit
1822
set -o nounset
1923
set -o pipefail

hack/verify-external-dependencies-version.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17+
# This script verifies that dependencies are up-to-date across different files
18+
# Usage: `hack/verify-external-dependencies-version.sh`.
19+
1720
set -o errexit
1821
set -o nounset
1922
set -o pipefail

0 commit comments

Comments
 (0)