Skip to content

Commit 59bc823

Browse files
committed
Delete namespace parameter in create adapter
1 parent 76e0e25 commit 59bc823

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

test/e2e/instrumentation/monitoring/custom_metrics_deployments.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -252,11 +252,11 @@ func prometheusExporterPodSpec(metricName string, metricValue int64, port int32)
252252

253253
// CreateAdapter creates Custom Metrics - Stackdriver adapter
254254
// adapterDeploymentFile should be a filename for adapter deployment located in StagingDeploymentLocation
255-
func CreateAdapter(namespace, adapterDeploymentFile string) error {
255+
func CreateAdapter(adapterDeploymentFile string) error {
256256
// A workaround to make the work on GKE. GKE doesn't normally allow to create cluster roles,
257257
// which the adapter deployment does. The solution is to create cluster role binding for
258258
// cluster-admin role and currently used service account.
259-
err := createClusterAdminBinding(namespace)
259+
err := createClusterAdminBinding()
260260
if err != nil {
261261
return err
262262
}
@@ -265,20 +265,20 @@ func CreateAdapter(namespace, adapterDeploymentFile string) error {
265265
if err != nil {
266266
return err
267267
}
268-
stat, err := framework.RunKubectl(namespace, "create", "-f", adapterURL)
268+
stat, err := framework.RunKubectl("create", "-f", adapterURL)
269269
framework.Logf(stat)
270270
return err
271271
}
272272

273-
func createClusterAdminBinding(namespace string) error {
273+
func createClusterAdminBinding() error {
274274
stdout, stderr, err := framework.RunCmd("gcloud", "config", "get-value", "core/account")
275275
if err != nil {
276276
framework.Logf(stderr)
277277
return err
278278
}
279279
serviceAccount := strings.TrimSpace(stdout)
280280
framework.Logf("current service account: %q", serviceAccount)
281-
stat, err := framework.RunKubectl(namespace, "create", "clusterrolebinding", ClusterAdminBinding, "--clusterrole=cluster-admin", "--user="+serviceAccount)
281+
stat, err := framework.RunKubectl("create", "clusterrolebinding", ClusterAdminBinding, "--clusterrole=cluster-admin", "--user="+serviceAccount)
282282
framework.Logf(stat)
283283
return err
284284
}

0 commit comments

Comments
 (0)