Merge pull request kubernetes#74505 from SataQiu/fix-golint-20190225

k8s-ci-robot · web-flow · commit 5a2d587ac4e0 · 2019-02-25T20:28:30.000-08:00
fix golint failures for pkg/apis/...
diff --git a/hack/.golint_failures b/hack/.golint_failures
@@ -7,7 +7,6 @@ cmd/kubeadm/app/apis/kubeadm/v1beta1
 cmd/kubeadm/app/util/system
 pkg/apis/abac/latest
 pkg/apis/admission
-pkg/apis/admission/v1beta1
 pkg/apis/admissionregistration
 pkg/apis/admissionregistration/v1beta1
 pkg/apis/admissionregistration/validation
@@ -19,10 +18,8 @@ pkg/apis/apps/validation
 pkg/apis/auditregistration/v1alpha1
 pkg/apis/authentication
 pkg/apis/authentication/v1
-pkg/apis/authentication/v1beta1
 pkg/apis/authorization
 pkg/apis/authorization/v1
-pkg/apis/authorization/v1beta1
 pkg/apis/authorization/validation
 pkg/apis/autoscaling
 pkg/apis/autoscaling/v1
@@ -38,8 +35,6 @@ pkg/apis/certificates
 pkg/apis/certificates/v1beta1
 pkg/apis/certificates/validation
 pkg/apis/coordination
-pkg/apis/coordination/v1
-pkg/apis/coordination/v1beta1
 pkg/apis/core
 pkg/apis/core/helper
 pkg/apis/core/helper/qos
@@ -53,7 +48,6 @@ pkg/apis/events/v1beta1
 pkg/apis/extensions
 pkg/apis/extensions/v1beta1
 pkg/apis/imagepolicy
-pkg/apis/imagepolicy/v1alpha1
 pkg/apis/networking
 pkg/apis/networking/v1
 pkg/apis/policy
@@ -65,15 +59,11 @@ pkg/apis/rbac/v1alpha1
 pkg/apis/rbac/v1beta1
 pkg/apis/rbac/validation
 pkg/apis/scheduling
-pkg/apis/scheduling/v1alpha1
-pkg/apis/scheduling/v1beta1
 pkg/apis/settings
-pkg/apis/settings/v1alpha1
 pkg/apis/storage
 pkg/apis/storage/util
 pkg/apis/storage/v1
 pkg/apis/storage/v1/util
-pkg/apis/storage/v1alpha1
 pkg/apis/storage/v1beta1
 pkg/apis/storage/v1beta1/util
 pkg/auth/authorizer/abac
diff --git a/pkg/apis/admission/v1beta1/register.go b/pkg/apis/admission/v1beta1/register.go
@@ -34,7 +34,8 @@ func Resource(resource string) schema.GroupResource {
 
 var (
 	localSchemeBuilder = &admissionv1beta1.SchemeBuilder
-	AddToScheme        = localSchemeBuilder.AddToScheme
+	// AddToScheme is a common registration function for mapping packaged scoped group & version keys to a scheme
+	AddToScheme = localSchemeBuilder.AddToScheme
 )
 
 func init() {
diff --git a/pkg/apis/authentication/v1beta1/register.go b/pkg/apis/authentication/v1beta1/register.go
@@ -34,7 +34,8 @@ func Resource(resource string) schema.GroupResource {
 
 var (
 	localSchemeBuilder = &authenticationv1beta1.SchemeBuilder
-	AddToScheme        = localSchemeBuilder.AddToScheme
+	// AddToScheme is a common registration function for mapping packaged scoped group & version keys to a scheme
+	AddToScheme = localSchemeBuilder.AddToScheme
 )
 
 func init() {
diff --git a/pkg/apis/authorization/v1beta1/register.go b/pkg/apis/authorization/v1beta1/register.go
@@ -34,7 +34,8 @@ func Resource(resource string) schema.GroupResource {
 
 var (
 	localSchemeBuilder = &authorizationv1beta1.SchemeBuilder
-	AddToScheme        = localSchemeBuilder.AddToScheme
+	// AddToScheme is a common registration function for mapping packaged scoped group & version keys to a scheme
+	AddToScheme = localSchemeBuilder.AddToScheme
 )
 
 func init() {
diff --git a/pkg/apis/coordination/v1/register.go b/pkg/apis/coordination/v1/register.go
@@ -34,7 +34,8 @@ func Resource(resource string) schema.GroupResource {
 
 var (
 	localSchemeBuilder = &coordinationv1.SchemeBuilder
-	AddToScheme        = localSchemeBuilder.AddToScheme
+	// AddToScheme is a common registration function for mapping packaged scoped group & version keys to a scheme
+	AddToScheme = localSchemeBuilder.AddToScheme
 )
 
 func init() {
diff --git a/pkg/apis/coordination/v1beta1/register.go b/pkg/apis/coordination/v1beta1/register.go
@@ -34,7 +34,8 @@ func Resource(resource string) schema.GroupResource {
 
 var (
 	localSchemeBuilder = &coordinationv1beta1.SchemeBuilder
-	AddToScheme        = localSchemeBuilder.AddToScheme
+	// AddToScheme is a common registration function for mapping packaged scoped group & version keys to a scheme
+	AddToScheme = localSchemeBuilder.AddToScheme
 )
 
 func init() {
diff --git a/pkg/apis/imagepolicy/v1alpha1/register.go b/pkg/apis/imagepolicy/v1alpha1/register.go
@@ -34,7 +34,8 @@ func Resource(resource string) schema.GroupResource {
 
 var (
 	localSchemeBuilder = &imagepolicyv1alpha1.SchemeBuilder
-	AddToScheme        = localSchemeBuilder.AddToScheme
+	// AddToScheme is a common registration function for mapping packaged scoped group & version keys to a scheme
+	AddToScheme = localSchemeBuilder.AddToScheme
 )
 
 func init() {
diff --git a/pkg/apis/scheduling/v1alpha1/register.go b/pkg/apis/scheduling/v1alpha1/register.go
@@ -34,7 +34,8 @@ func Resource(resource string) schema.GroupResource {
 
 var (
 	localSchemeBuilder = &schedulingv1alpha1.SchemeBuilder
-	AddToScheme        = localSchemeBuilder.AddToScheme
+	// AddToScheme is a common registration function for mapping packaged scoped group & version keys to a scheme
+	AddToScheme = localSchemeBuilder.AddToScheme
 )
 
 func init() {
diff --git a/pkg/apis/scheduling/v1beta1/register.go b/pkg/apis/scheduling/v1beta1/register.go
@@ -34,7 +34,8 @@ func Resource(resource string) schema.GroupResource {
 
 var (
 	localSchemeBuilder = &schedulingv1beta1.SchemeBuilder
-	AddToScheme        = localSchemeBuilder.AddToScheme
+	// AddToScheme is a common registration function for mapping packaged scoped group & version keys to a scheme
+	AddToScheme = localSchemeBuilder.AddToScheme
 )
 
 func init() {
diff --git a/pkg/apis/settings/v1alpha1/register.go b/pkg/apis/settings/v1alpha1/register.go
@@ -34,7 +34,8 @@ func Resource(resource string) schema.GroupResource {
 
 var (
 	localSchemeBuilder = &settingsv1alpha1.SchemeBuilder
-	AddToScheme        = localSchemeBuilder.AddToScheme
+	// AddToScheme is a common registration function for mapping packaged scoped group & version keys to a scheme
+	AddToScheme = localSchemeBuilder.AddToScheme
 )
 
 func init() {
diff --git a/pkg/apis/storage/v1alpha1/register.go b/pkg/apis/storage/v1alpha1/register.go
@@ -34,5 +34,6 @@ func Resource(resource string) schema.GroupResource {
 
 var (
 	localSchemeBuilder = &storagev1alpha1.SchemeBuilder
-	AddToScheme        = localSchemeBuilder.AddToScheme
+	// AddToScheme is a common registration function for mapping packaged scoped group & version keys to a scheme
+	AddToScheme = localSchemeBuilder.AddToScheme
 )

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,8 @@ func Resource(resource string) schema.GroupResource {`
`34`	`34`
`35`	`35`	`var (`
`36`	`36`	`localSchemeBuilder = &admissionv1beta1.SchemeBuilder`
`37`		`- AddToScheme = localSchemeBuilder.AddToScheme`
	`37`	`+ // AddToScheme is a common registration function for mapping packaged scoped group & version keys to a scheme`
	`38`	`+ AddToScheme = localSchemeBuilder.AddToScheme`
`38`	`39`	`)`
`39`	`40`
`40`	`41`	`func init() {`