Skip to content

Commit 5b1fb22

Browse files
committed
increase pv controller resync period to try to deflake api update conflicts
1 parent 384e45f commit 5b1fb22

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

test/integration/volumescheduling/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ go_test(
1717
tags = ["integration"],
1818
deps = [
1919
"//pkg/controller/volume/persistentvolume:go_default_library",
20-
"//pkg/controller/volume/persistentvolume/options:go_default_library",
2120
"//pkg/scheduler/algorithm/predicates:go_default_library",
2221
"//pkg/volume:go_default_library",
2322
"//pkg/volume/testing:go_default_library",

test/integration/volumescheduling/volume_binding_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ import (
4040
clientset "k8s.io/client-go/kubernetes"
4141
"k8s.io/client-go/util/workqueue"
4242
"k8s.io/kubernetes/pkg/controller/volume/persistentvolume"
43-
persistentvolumeoptions "k8s.io/kubernetes/pkg/controller/volume/persistentvolume/options"
4443
"k8s.io/kubernetes/pkg/scheduler/algorithm/predicates"
4544
"k8s.io/kubernetes/pkg/volume"
4645
volumetest "k8s.io/kubernetes/pkg/volume/testing"
@@ -926,7 +925,7 @@ func setupCluster(t *testing.T, nsName string, numberOfNodes int, resyncPeriod t
926925

927926
func initPVController(context *testContext, provisionDelaySeconds int) (*persistentvolume.PersistentVolumeController, informers.SharedInformerFactory, error) {
928927
clientset := context.clientSet
929-
// Informers factory for controllers, we disable resync period for testing.
928+
// Informers factory for controllers
930929
informerFactory := informers.NewSharedInformerFactory(clientset, 0)
931930

932931
// Start PV controller for volume binding.
@@ -946,10 +945,11 @@ func initPVController(context *testContext, provisionDelaySeconds int) (*persist
946945
}
947946
plugins := []volume.VolumePlugin{plugin}
948947

949-
controllerOptions := persistentvolumeoptions.NewPersistentVolumeControllerOptions()
950948
params := persistentvolume.ControllerParameters{
951-
KubeClient: clientset,
952-
SyncPeriod: controllerOptions.PVClaimBinderSyncPeriod,
949+
KubeClient: clientset,
950+
// Use a frequent resync period to retry API update conflicts due to
951+
// https://github.com/kubernetes/kubernetes/issues/85320
952+
SyncPeriod: 5 * time.Second,
953953
VolumePlugins: plugins,
954954
Cloud: nil,
955955
ClusterName: "volume-test-cluster",

0 commit comments

Comments
 (0)