Skip to content

Commit 5de4134

Browse files
authored
Merge pull request kubernetes#80266 from javier-b-perez/bazel-build
build: bazel: release tars should use arch in the name
2 parents 91e17af + b6508bc commit 5de4134

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

build/BUILD

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,8 @@ DOCKERIZED_BINARIES = {
5252
},
5353
}
5454

55-
# In the bash-based build (build/lib/release.sh), the images built for amd64 do not use
56-
# an arch in their name (but other arches do), and the GCE cluster scripts
57-
# (which sideload the images via tarfiles) expect there not to be an arch.
5855
# When pushing to gcr.io, we want to use an arch, since the archless name is now used for a
5956
# manifest list. Bazel doesn't support manifest lists (yet), so we can't do that either.
60-
# For now, we use the archless name for the image tars saved in the server tarball,
61-
# to satisfy GCE and other similar providers. (If one were to pull the images via the manifest
62-
# list, the arch wouldn't appear in the name either.)
6357
[multi_arch_container(
6458
name = binary,
6559
architectures = SERVER_PLATFORMS["linux"],
@@ -71,10 +65,8 @@ DOCKERIZED_BINARIES = {
7165
)),
7266
# Since the multi_arch_container macro replaces the {ARCH} format string,
7367
# we need to escape the stamping vars.
74-
# Also see comment above about why the push tags use ARCH while the
75-
# non-push tags do not.
7668
docker_push_tags = ["{{STABLE_DOCKER_PUSH_REGISTRY}}/%s-{ARCH}:{{STABLE_DOCKER_TAG}}" % binary],
77-
docker_tags = ["{{STABLE_DOCKER_REGISTRY}}/%s:{{STABLE_DOCKER_TAG}}" % binary],
69+
docker_tags = ["{{STABLE_DOCKER_REGISTRY}}/%s-{ARCH}:{{STABLE_DOCKER_TAG}}" % binary],
7870
stamp = True,
7971
symlinks = {
8072
# Some cluster startup scripts expect to find the binaries in /usr/local/bin,

0 commit comments

Comments
 (0)