Skip to content

Commit 5e3f3b3

Browse files
committed
Review comments
Signed-off-by: Jean Rouge <[email protected]>
1 parent 1908a0c commit 5e3f3b3

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

pkg/kubelet/dockershim/docker_container.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,10 @@ func (ds *dockerService) CreateContainer(_ context.Context, r *runtimeapi.Create
177177
containerID := createResp.ID
178178

179179
if cleanupInfo != nil {
180-
// save it for when the container starts or gets removed
180+
// we don't perform the clean up just yet at that could destroy information
181+
// needed for the container to start (e.g. Windows credentials stored in
182+
// registry keys); instead, we'll clean up after the container successfully
183+
// starts or gets removed
181184
ds.containerCleanupInfos[containerID] = cleanupInfo
182185
}
183186
return &runtimeapi.CreateContainerResponse{ContainerId: containerID}, nil

0 commit comments

Comments
 (0)