Skip to content

Commit 5e7ed7b

Browse files
committed
Re-add the event recorder in the release test
Prior having a mock recorder would cause panics since the lock would be set to nil on update failures. Now the recorder will use the cached lock
1 parent 8160ecf commit 5e7ed7b

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

staging/src/k8s.io/client-go/tools/leaderelection/leaderelection_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1097,9 +1097,8 @@ func testReleaseOnCancellation(t *testing.T, objectType string) {
10971097
)
10981098

10991099
resourceLockConfig := rl.ResourceLockConfig{
1100-
Identity: "baz",
1101-
// TODO - uncomment this to introduce errors
1102-
// EventRecorder: &record.FakeRecorder{},
1100+
Identity: "baz",
1101+
EventRecorder: &record.FakeRecorder{},
11031102
}
11041103
c := &fake.Clientset{}
11051104

0 commit comments

Comments
 (0)