Merge pull request kubernetes#74574 from SataQiu/fix-golint-20190226

k8s-ci-robot · web-flow · commit 5ebdf3e3f211 · 2019-02-26T18:12:19.000-08:00
fix some golint failures in pkg/registry/...
diff --git a/hack/.golint_failures b/hack/.golint_failures
@@ -225,14 +225,11 @@ pkg/quota/v1/evaluator/core
 pkg/registry/admissionregistration/mutatingwebhookconfiguration/storage
 pkg/registry/admissionregistration/rest
 pkg/registry/admissionregistration/validatingwebhookconfiguration/storage
-pkg/registry/apps/daemonset
 pkg/registry/apps/daemonset/storage
-pkg/registry/apps/deployment
 pkg/registry/apps/deployment/storage
 pkg/registry/apps/replicaset
 pkg/registry/apps/replicaset/storage
 pkg/registry/apps/rest
-pkg/registry/apps/statefulset
 pkg/registry/apps/statefulset/storage
 pkg/registry/auditregistration/rest
 pkg/registry/authentication/rest
@@ -241,10 +238,8 @@ pkg/registry/authorization/localsubjectaccessreview
 pkg/registry/authorization/rest
 pkg/registry/authorization/selfsubjectaccessreview
 pkg/registry/authorization/subjectaccessreview
-pkg/registry/autoscaling/horizontalpodautoscaler
 pkg/registry/autoscaling/horizontalpodautoscaler/storage
 pkg/registry/autoscaling/rest
-pkg/registry/batch/cronjob
 pkg/registry/batch/cronjob/storage
 pkg/registry/batch/job
 pkg/registry/batch/job/storage
@@ -271,7 +266,6 @@ pkg/registry/core/pod/rest
 pkg/registry/core/podtemplate/storage
 pkg/registry/core/replicationcontroller
 pkg/registry/core/replicationcontroller/storage
-pkg/registry/core/resourcequota
 pkg/registry/core/resourcequota/storage
 pkg/registry/core/rest
 pkg/registry/core/secret
@@ -289,7 +283,6 @@ pkg/registry/extensions/controller/storage
 pkg/registry/extensions/rest
 pkg/registry/networking/networkpolicy/storage
 pkg/registry/networking/rest
-pkg/registry/policy/poddisruptionbudget
 pkg/registry/policy/poddisruptionbudget/storage
 pkg/registry/policy/rest
 pkg/registry/rbac/clusterrole
diff --git a/pkg/registry/apps/daemonset/strategy.go b/pkg/registry/apps/daemonset/strategy.go
@@ -166,6 +166,7 @@ type daemonSetStatusStrategy struct {
 	daemonSetStrategy
 }
 
+// StatusStrategy is the default logic invoked when updating object status.
 var StatusStrategy = daemonSetStatusStrategy{Strategy}
 
 func (daemonSetStatusStrategy) PrepareForUpdate(ctx context.Context, obj, old runtime.Object) {
diff --git a/pkg/registry/apps/deployment/strategy.go b/pkg/registry/apps/deployment/strategy.go
@@ -145,6 +145,7 @@ type deploymentStatusStrategy struct {
 	deploymentStrategy
 }
 
+// StatusStrategy is the default logic invoked when updating object status.
 var StatusStrategy = deploymentStatusStrategy{Strategy}
 
 // PrepareForUpdate clears fields that are not allowed to be set by end users on update of status
diff --git a/pkg/registry/apps/statefulset/strategy.go b/pkg/registry/apps/statefulset/strategy.go
@@ -130,6 +130,7 @@ type statefulSetStatusStrategy struct {
 	statefulSetStrategy
 }
 
+// StatusStrategy is the default logic invoked when updating object status.
 var StatusStrategy = statefulSetStatusStrategy{Strategy}
 
 // PrepareForUpdate clears fields that are not allowed to be set by end users on update of status
diff --git a/pkg/registry/autoscaling/horizontalpodautoscaler/strategy.go b/pkg/registry/autoscaling/horizontalpodautoscaler/strategy.go
@@ -86,6 +86,7 @@ type autoscalerStatusStrategy struct {
 	autoscalerStrategy
 }
 
+// StatusStrategy is the default logic invoked when updating object status.
 var StatusStrategy = autoscalerStatusStrategy{Strategy}
 
 func (autoscalerStatusStrategy) PrepareForUpdate(ctx context.Context, obj, old runtime.Object) {
diff --git a/pkg/registry/batch/cronjob/strategy.go b/pkg/registry/batch/cronjob/strategy.go
@@ -118,6 +118,7 @@ type cronJobStatusStrategy struct {
 	cronJobStrategy
 }
 
+// StatusStrategy is the default logic invoked when updating object status.
 var StatusStrategy = cronJobStatusStrategy{Strategy}
 
 func (cronJobStatusStrategy) PrepareForUpdate(ctx context.Context, obj, old runtime.Object) {
diff --git a/pkg/registry/core/resourcequota/strategy.go b/pkg/registry/core/resourcequota/strategy.go
@@ -87,6 +87,7 @@ type resourcequotaStatusStrategy struct {
 	resourcequotaStrategy
 }
 
+// StatusStrategy is the default logic invoked when updating object status.
 var StatusStrategy = resourcequotaStatusStrategy{Strategy}
 
 func (resourcequotaStatusStrategy) PrepareForUpdate(ctx context.Context, obj, old runtime.Object) {
diff --git a/pkg/registry/policy/poddisruptionbudget/strategy.go b/pkg/registry/policy/poddisruptionbudget/strategy.go
@@ -98,6 +98,7 @@ type podDisruptionBudgetStatusStrategy struct {
 	podDisruptionBudgetStrategy
 }
 
+// StatusStrategy is the default logic invoked when updating object status.
 var StatusStrategy = podDisruptionBudgetStatusStrategy{Strategy}
 
 // PrepareForUpdate clears fields that are not allowed to be set by end users on update of status

Original file line number	Diff line number	Diff line change
`@@ -166,6 +166,7 @@ type daemonSetStatusStrategy struct {`
`166`	`166`	`daemonSetStrategy`
`167`	`167`	`}`
`168`	`168`
	`169`	`+// StatusStrategy is the default logic invoked when updating object status.`
`169`	`170`	`var StatusStrategy = daemonSetStatusStrategy{Strategy}`
`170`	`171`
`171`	`172`	`func (daemonSetStatusStrategy) PrepareForUpdate(ctx context.Context, obj, old runtime.Object) {`
Original file line number	Diff line number	Diff line change
`@@ -145,6 +145,7 @@ type deploymentStatusStrategy struct {`
`145`	`145`	`deploymentStrategy`
`146`	`146`	`}`
`147`	`147`
	`148`	`+// StatusStrategy is the default logic invoked when updating object status.`
`148`	`149`	`var StatusStrategy = deploymentStatusStrategy{Strategy}`
`149`	`150`
`150`	`151`	`// PrepareForUpdate clears fields that are not allowed to be set by end users on update of status`
Original file line number	Diff line number	Diff line change
`@@ -130,6 +130,7 @@ type statefulSetStatusStrategy struct {`
`130`	`130`	`statefulSetStrategy`
`131`	`131`	`}`
`132`	`132`
	`133`	`+// StatusStrategy is the default logic invoked when updating object status.`
`133`	`134`	`var StatusStrategy = statefulSetStatusStrategy{Strategy}`
`134`	`135`
`135`	`136`	`// PrepareForUpdate clears fields that are not allowed to be set by end users on update of status`
Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,7 @@ type autoscalerStatusStrategy struct {`
`86`	`86`	`autoscalerStrategy`
`87`	`87`	`}`
`88`	`88`
	`89`	`+// StatusStrategy is the default logic invoked when updating object status.`
`89`	`90`	`var StatusStrategy = autoscalerStatusStrategy{Strategy}`
`90`	`91`
`91`	`92`	`func (autoscalerStatusStrategy) PrepareForUpdate(ctx context.Context, obj, old runtime.Object) {`
Original file line number	Diff line number	Diff line change
`@@ -118,6 +118,7 @@ type cronJobStatusStrategy struct {`
`118`	`118`	`cronJobStrategy`
`119`	`119`	`}`
`120`	`120`
	`121`	`+// StatusStrategy is the default logic invoked when updating object status.`
`121`	`122`	`var StatusStrategy = cronJobStatusStrategy{Strategy}`
`122`	`123`
`123`	`124`	`func (cronJobStatusStrategy) PrepareForUpdate(ctx context.Context, obj, old runtime.Object) {`
Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,7 @@ type resourcequotaStatusStrategy struct {`
`87`	`87`	`resourcequotaStrategy`
`88`	`88`	`}`
`89`	`89`
	`90`	`+// StatusStrategy is the default logic invoked when updating object status.`
`90`	`91`	`var StatusStrategy = resourcequotaStatusStrategy{Strategy}`
`91`	`92`
`92`	`93`	`func (resourcequotaStatusStrategy) PrepareForUpdate(ctx context.Context, obj, old runtime.Object) {`
Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,7 @@ type podDisruptionBudgetStatusStrategy struct {`
`98`	`98`	`podDisruptionBudgetStrategy`
`99`	`99`	`}`
`100`	`100`
	`101`	`+// StatusStrategy is the default logic invoked when updating object status.`
`101`	`102`	`var StatusStrategy = podDisruptionBudgetStatusStrategy{Strategy}`
`102`	`103`
`103`	`104`	`// PrepareForUpdate clears fields that are not allowed to be set by end users on update of status`