Skip to content

Commit 63c0113

Browse files
committed
proxy/userspace: add dcbw and danwinship to OWNERS approvers
Per recommendation of @thockin: kubernetes#71735 (review) --- IMO this code is as dead as it could be. The only significant user is OpenShift as far as I know. I'd rather never touch it again, but I know that is not realistic. Also, it seems like maybe this could be broken into a couple commits for easier review? I raised some questions about this design, but I think you should add yourselves as approvers in OWNERS for this subdir. If it evolves, I will lose context on the impl. I don't think it is covered by e2e, either (more argument for breaking it to a separate repo and having its own e2e tests) ---
1 parent 8a2f8e6 commit 63c0113

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

pkg/proxy/userspace/OWNERS

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,15 @@
11
# See the OWNERS docs at https://go.k8s.io/owners
22

3+
approvers:
4+
- thockin
5+
- dcbw
6+
- danwinship
37
reviewers:
48
- thockin
59
- lavalamp
610
- smarterclayton
711
- freehan
12+
- dcbw
13+
- danwinship
814
labels:
915
- sig/network

0 commit comments

Comments
 (0)