Merge pull request kubernetes#92430 from wangkai1994/fix/garbagecollector-staticcheck

k8s-ci-robot · web-flow · commit 67a7509ef30a · 2020-08-27T17:57:22.000-07:00
Fix staticcheck failures for pkg/controller/garbagecollector/garbagecollector_test.go
diff --git a/hack/.staticcheck_failures b/hack/.staticcheck_failures
@@ -1,5 +1,4 @@
 cluster/images/etcd/migrate
-pkg/controller/garbagecollector
 pkg/controller/podautoscaler
 pkg/controller/replicaset
 pkg/controller/resourcequota
diff --git a/pkg/controller/garbagecollector/garbagecollector_test.go b/pkg/controller/garbagecollector/garbagecollector_test.go
@@ -906,7 +906,7 @@ func expectSyncNotBlocked(fakeDiscoveryClient *fakeServerResources, workerLock *
 	workerLockAcquired := make(chan struct{})
 	go func() {
 		workerLock.Lock()
-		workerLock.Unlock()
+		defer workerLock.Unlock()
 		close(workerLockAcquired)
 	}()
 	select {

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`cluster/images/etcd/migrate`
`2`		`-pkg/controller/garbagecollector`
`3`	`2`	`pkg/controller/podautoscaler`
`4`	`3`	`pkg/controller/replicaset`
`5`	`4`	`pkg/controller/resourcequota`