Merge pull request kubernetes#91048 from pjbgf/fix-error-validation

k8s-ci-robot · web-flow · commit 6b65bc7395c4 · 2020-07-01T02:54:16.000-07:00
linkcheck: Fix incorrect error validation for Retry-After
diff --git a/cmd/linkcheck/links.go b/cmd/linkcheck/links.go
@@ -134,7 +134,7 @@ func newWalkFunc(invalidLink *bool, client *http.Client) filepath.WalkFunc {
 				// And Go client will follow redirects automatically so the 301 check is probably unnecessary.
 				if resp.StatusCode == http.StatusTooManyRequests || resp.StatusCode == http.StatusServiceUnavailable {
 					retryAfter := resp.Header.Get("Retry-After")
-					if seconds, err := strconv.Atoi(retryAfter); err != nil {
+					if seconds, err := strconv.Atoi(retryAfter); err == nil {
 						backoff = seconds + 10
 					}
 					fmt.Fprintf(os.Stderr, "Got %d visiting %s, retry after %d seconds.\n", resp.StatusCode, string(URL), backoff)

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ func newWalkFunc(invalidLink bool, client http.Client) filepath.WalkFunc {`
`134`	`134`	`// And Go client will follow redirects automatically so the 301 check is probably unnecessary.`
`135`	`135`	`if resp.StatusCode == http.StatusTooManyRequests \|\| resp.StatusCode == http.StatusServiceUnavailable {`
`136`	`136`	`retryAfter := resp.Header.Get("Retry-After")`
`137`		`- if seconds, err := strconv.Atoi(retryAfter); err != nil {`
	`137`	`+ if seconds, err := strconv.Atoi(retryAfter); err == nil {`
`138`	`138`	`backoff = seconds + 10`
`139`	`139`	`}`
`140`	`140`	`fmt.Fprintf(os.Stderr, "Got %d visiting %s, retry after %d seconds.\n", resp.StatusCode, string(URL), backoff)`