storage: fix CSIInlineVolume round-trip test

pohly · pohly · commit 6d12f2de1027 · 2019-08-27T14:00:42.000+02:00
When adding CSIDriver.Spec.VolumeLifecycleModes, the defaulting in
pkg/apis/storage/fuzzer/fuzzer.go did not quite match the one from
pkg/apis/storage/v1beta1/defaults.go, causing a test failure when the
corresponding feature gate is enabled.
diff --git a/pkg/apis/storage/fuzzer/fuzzer.go b/pkg/apis/storage/fuzzer/fuzzer.go
@@ -78,7 +78,7 @@ var Funcs = func(codecs runtimeserializer.CodecFactory) []interface{} {
 				obj.Spec.PodInfoOnMount = new(bool)
 				*(obj.Spec.PodInfoOnMount) = false
 			}
-			if obj.Spec.VolumeLifecycleModes == nil {
+			if len(obj.Spec.VolumeLifecycleModes) == 0 {
 				obj.Spec.VolumeLifecycleModes = []storage.VolumeLifecycleMode{
 					storage.VolumeLifecyclePersistent,
 				}

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ var Funcs = func(codecs runtimeserializer.CodecFactory) []interface{} {`
`78`	`78`	`obj.Spec.PodInfoOnMount = new(bool)`
`79`	`79`	`*(obj.Spec.PodInfoOnMount) = false`
`80`	`80`	`}`
`81`		`- if obj.Spec.VolumeLifecycleModes == nil {`
	`81`	`+ if len(obj.Spec.VolumeLifecycleModes) == 0 {`
`82`	`82`	`obj.Spec.VolumeLifecycleModes = []storage.VolumeLifecycleMode{`
`83`	`83`	`storage.VolumeLifecyclePersistent,`
`84`	`84`	`}`