Skip to content

Commit 73375fb

Browse files
authored
Merge pull request kubernetes#94552 from justaugustus/fix-go-runner-arch
build: Fix go-runner arch in server images
2 parents d239cdf + 3ab1a49 commit 73375fb

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

build/common.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,6 @@ readonly KUBE_CONTAINER_RSYNC_PORT=8730
9393
#
9494
# $1 - server architecture
9595
kube::build::get_docker_wrapped_binaries() {
96-
local arch=$1
97-
local debian_base_version=v2.1.3
9896
local debian_iptables_version=v12.1.2
9997
local go_runner_version=buster-v2.0.0
10098
### If you change any of these lists, please also update DOCKERIZED_BINARIES
@@ -103,7 +101,7 @@ kube::build::get_docker_wrapped_binaries() {
103101
"kube-apiserver,${KUBE_BASE_IMAGE_REGISTRY}/go-runner:${go_runner_version}"
104102
"kube-controller-manager,${KUBE_BASE_IMAGE_REGISTRY}/go-runner:${go_runner_version}"
105103
"kube-scheduler,${KUBE_BASE_IMAGE_REGISTRY}/go-runner:${go_runner_version}"
106-
"kube-proxy,${KUBE_BASE_IMAGE_REGISTRY}/debian-iptables-${arch}:${debian_iptables_version}"
104+
"kube-proxy,${KUBE_BASE_IMAGE_REGISTRY}/debian-iptables:${debian_iptables_version}"
107105
)
108106

109107
echo "${targets[@]}"

build/dependencies.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,6 @@ dependencies:
118118
- name: "k8s.gcr.io/debian-base: dependents"
119119
version: 2.1.3
120120
refPaths:
121-
- path: build/common.sh
122-
match: debian_base_version=
123121
- path: build/workspace.bzl
124122
match: tag =
125123
- path: cluster/images/etcd/Makefile

build/lib/release.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ function kube::release::create_docker_images_for_server() {
334334
local images_dir
335335
binary_dir="$1"
336336
arch="$2"
337-
binaries=$(kube::build::get_docker_wrapped_binaries "${arch}")
337+
binaries=$(kube::build::get_docker_wrapped_binaries)
338338
images_dir="${RELEASE_IMAGES}/${arch}"
339339
mkdir -p "${images_dir}"
340340

@@ -375,7 +375,7 @@ function kube::release::create_docker_images_for_server() {
375375
ln "${KUBE_ROOT}/build/nsswitch.conf" "${docker_build_path}/nsswitch.conf"
376376
chmod 0644 "${docker_build_path}/nsswitch.conf"
377377
cat <<EOF > "${docker_file_path}"
378-
FROM ${base_image}
378+
FROM --platform=linux/${arch} ${base_image}
379379
COPY ${binary_name} /usr/local/bin/${binary_name}
380380
EOF
381381
# ensure /etc/nsswitch.conf exists so go's resolver respects /etc/hosts

0 commit comments

Comments
 (0)