Merge pull request kubernetes#75584 from SataQiu/fix-golint-20190322

k8s-ci-robot · web-flow · commit 733f2478d387 · 2019-03-29T10:28:40.000-07:00
fix some golint failures in pkg/apis
diff --git a/hack/.golint_failures b/hack/.golint_failures
@@ -15,7 +15,6 @@ pkg/apis/apps/v1beta1
 pkg/apis/apps/v1beta2
 pkg/apis/apps/validation
 pkg/apis/auditregistration/v1alpha1
-pkg/apis/authentication
 pkg/apis/authentication/v1
 pkg/apis/authorization
 pkg/apis/authorization/v1
@@ -33,7 +32,6 @@ pkg/apis/batch/validation
 pkg/apis/certificates
 pkg/apis/certificates/v1beta1
 pkg/apis/certificates/validation
-pkg/apis/coordination
 pkg/apis/core
 pkg/apis/core/helper
 pkg/apis/core/helper/qos
@@ -42,11 +40,9 @@ pkg/apis/core/v1/helper
 pkg/apis/core/v1/helper/qos
 pkg/apis/core/v1/validation
 pkg/apis/core/validation
-pkg/apis/events
 pkg/apis/events/v1beta1
 pkg/apis/extensions
 pkg/apis/extensions/v1beta1
-pkg/apis/imagepolicy
 pkg/apis/networking
 pkg/apis/networking/v1
 pkg/apis/node/v1alpha1
@@ -59,7 +55,6 @@ pkg/apis/rbac/v1alpha1
 pkg/apis/rbac/v1beta1
 pkg/apis/rbac/validation
 pkg/apis/scheduling
-pkg/apis/settings
 pkg/apis/storage
 pkg/apis/storage/util
 pkg/apis/storage/v1
diff --git a/pkg/apis/authentication/register.go b/pkg/apis/authentication/register.go
@@ -38,8 +38,10 @@ func Resource(resource string) schema.GroupResource {
 }
 
 var (
+	// SchemeBuilder points to a list of functions added to Scheme.
 	SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)
-	AddToScheme   = SchemeBuilder.AddToScheme
+	// AddToScheme applies all the stored functions to the scheme.
+	AddToScheme = SchemeBuilder.AddToScheme
 )
 
 func addKnownTypes(scheme *runtime.Scheme) error {
diff --git a/pkg/apis/coordination/register.go b/pkg/apis/coordination/register.go
@@ -38,8 +38,10 @@ func Resource(resource string) schema.GroupResource {
 }
 
 var (
+	// SchemeBuilder points to a list of functions added to Scheme.
 	SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)
-	AddToScheme   = SchemeBuilder.AddToScheme
+	// AddToScheme applies all the stored functions to the scheme.
+	AddToScheme = SchemeBuilder.AddToScheme
 )
 
 // Adds the list of known types to the given scheme.
diff --git a/pkg/apis/events/register.go b/pkg/apis/events/register.go
@@ -39,8 +39,10 @@ func Resource(resource string) schema.GroupResource {
 }
 
 var (
+	// SchemeBuilder points to a list of functions added to Scheme.
 	SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)
-	AddToScheme   = SchemeBuilder.AddToScheme
+	// AddToScheme applies all the stored functions to the scheme.
+	AddToScheme = SchemeBuilder.AddToScheme
 )
 
 func addKnownTypes(scheme *runtime.Scheme) error {
diff --git a/pkg/apis/imagepolicy/register.go b/pkg/apis/imagepolicy/register.go
@@ -38,8 +38,10 @@ func Resource(resource string) schema.GroupResource {
 }
 
 var (
+	// SchemeBuilder points to a list of functions added to Scheme.
 	SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)
-	AddToScheme   = SchemeBuilder.AddToScheme
+	// AddToScheme applies all the stored functions to the scheme.
+	AddToScheme = SchemeBuilder.AddToScheme
 )
 
 func addKnownTypes(scheme *runtime.Scheme) error {
diff --git a/pkg/apis/settings/register.go b/pkg/apis/settings/register.go
@@ -22,8 +22,10 @@ import (
 )
 
 var (
+	// SchemeBuilder points to a list of functions added to Scheme.
 	SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)
-	AddToScheme   = SchemeBuilder.AddToScheme
+	// AddToScheme applies all the stored functions to the scheme.
+	AddToScheme = SchemeBuilder.AddToScheme
 )
 
 // GroupName is the group name use in this package

Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,10 @@ func Resource(resource string) schema.GroupResource {`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`var (`
	`41`	`+ // SchemeBuilder points to a list of functions added to Scheme.`
`41`	`42`	`SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)`
`42`		`- AddToScheme = SchemeBuilder.AddToScheme`
	`43`	`+ // AddToScheme applies all the stored functions to the scheme.`
	`44`	`+ AddToScheme = SchemeBuilder.AddToScheme`
`43`	`45`	`)`
`44`	`46`
`45`	`47`	`func addKnownTypes(scheme *runtime.Scheme) error {`
Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,10 @@ func Resource(resource string) schema.GroupResource {`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`var (`
	`42`	`+ // SchemeBuilder points to a list of functions added to Scheme.`
`42`	`43`	`SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)`
`43`		`- AddToScheme = SchemeBuilder.AddToScheme`
	`44`	`+ // AddToScheme applies all the stored functions to the scheme.`
	`45`	`+ AddToScheme = SchemeBuilder.AddToScheme`
`44`	`46`	`)`
`45`	`47`
`46`	`48`	`func addKnownTypes(scheme *runtime.Scheme) error {`
Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,10 @@ import (`
`22`	`22`	`)`
`23`	`23`
`24`	`24`	`var (`
	`25`	`+ // SchemeBuilder points to a list of functions added to Scheme.`
`25`	`26`	`SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)`
`26`		`- AddToScheme = SchemeBuilder.AddToScheme`
	`27`	`+ // AddToScheme applies all the stored functions to the scheme.`
	`28`	`+ AddToScheme = SchemeBuilder.AddToScheme`
`27`	`29`	`)`
`28`	`30`
`29`	`31`	`// GroupName is the group name use in this package`